* [PATCH v2] ASoC: codecs: Fix error handling in aw_dev_get_dsp_status()
@ 2024-10-09 9:43 Zhu Jun
2024-10-09 11:12 ` [PATCH v3?] ASoC: codecs: aw88399: " Markus Elfring
0 siblings, 1 reply; 3+ messages in thread
From: Zhu Jun @ 2024-10-09 9:43 UTC (permalink / raw)
To: tiwai
Cc: wangweidong.a, perex, andriy.shevchenko, heiko, nathan,
u.kleine-koenig, zhujun2, linux-sound, linux-kernel
Changed the error handling in aw_dev_get_dsp_status to return -EPERM directly
instead of setting it to a variable.
Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
---
V1 -> V2:
- add a dot after the commit
- modify commit info
sound/soc/codecs/aw88399.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/aw88399.c b/sound/soc/codecs/aw88399.c
index 8dc2b8aa6832..bba59885242d 100644
--- a/sound/soc/codecs/aw88399.c
+++ b/sound/soc/codecs/aw88399.c
@@ -656,7 +656,7 @@ static int aw_dev_get_dsp_status(struct aw_device *aw_dev)
if (ret)
return ret;
if (!(reg_val & (~AW88399_WDT_CNT_MASK)))
- ret = -EPERM;
+ return -EPERM;
return 0;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3?] ASoC: codecs: aw88399: Fix error handling in aw_dev_get_dsp_status()
2024-10-09 9:43 [PATCH v2] ASoC: codecs: Fix error handling in aw_dev_get_dsp_status() Zhu Jun
@ 2024-10-09 11:12 ` Markus Elfring
2024-10-09 12:47 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Markus Elfring @ 2024-10-09 11:12 UTC (permalink / raw)
To: Zhu Jun, linux-sound, Jaroslav Kysela, Takashi Iwai
Cc: LKML, Andy Shevchenko, Heiko Stübner, Kuninori Morimoto,
Liam Girdwood, Mark Brown, Nathan Chancellor,
Uwe Kleine-König, Weidong Wang
> Changed the error handling in aw_dev_get_dsp_status to return -EPERM directly
> instead of setting it to a variable.
* How do you think about to choose an imperative wording for an improved change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n94
* Would you like to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n145
…
> ---
> V1 -> V2:
> - add a dot after the commit
> - modify commit info
Can it be that higher version numbers would be more appropriate according to
the evolving patch review?
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3?] ASoC: codecs: aw88399: Fix error handling in aw_dev_get_dsp_status()
2024-10-09 11:12 ` [PATCH v3?] ASoC: codecs: aw88399: " Markus Elfring
@ 2024-10-09 12:47 ` Mark Brown
0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2024-10-09 12:47 UTC (permalink / raw)
To: Markus Elfring
Cc: Zhu Jun, linux-sound, Jaroslav Kysela, Takashi Iwai, LKML,
Andy Shevchenko, Heiko Stübner, Kuninori Morimoto,
Liam Girdwood, Nathan Chancellor, Uwe Kleine-König,
Weidong Wang
[-- Attachment #1: Type: text/plain, Size: 433 bytes --]
On Wed, Oct 09, 2024 at 01:12:21PM +0200, Markus Elfring wrote:
> > Changed the error handling in aw_dev_get_dsp_status to return -EPERM directly
> > instead of setting it to a variable.
>
> * How do you think about to choose an imperative wording for an improved change description?
Feel free to ignore Markus, he has a long history of sending
unhelpful review comments and continues to ignore repeated requests
to stop.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-09 12:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-09 9:43 [PATCH v2] ASoC: codecs: Fix error handling in aw_dev_get_dsp_status() Zhu Jun
2024-10-09 11:12 ` [PATCH v3?] ASoC: codecs: aw88399: " Markus Elfring
2024-10-09 12:47 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox