Question about conversion kcontrol to component

Question about conversion kcontrol to component

[Kuninori Morimoto]

Hi ALSA ML

I have noticed that we have similar functions

	snd_soc_kcontrol_component()
	snd_soc_dapm_kcontrol_component()

Both converts snd_kcontrol to snd_soc_component.
I wonder can we merge these ? or which we can use is case-by-case ?

Thank you for your help !!

Best regards
---
Kuninori Morimoto

Re: Question about conversion kcontrol to component

[Charles Keepax]

On Fri, Apr 25, 2025 at 04:16:10AM +0000, Kuninori Morimoto wrote:
> 
> Hi ALSA ML
> 
> I have noticed that we have similar functions
> 
> 	snd_soc_kcontrol_component()
> 	snd_soc_dapm_kcontrol_component()
> 
> Both converts snd_kcontrol to snd_soc_component.
> I wonder can we merge these ? or which we can use is case-by-case ?
> 

I think this is case-by-case snd_soc_kcontrol_component() relies on
the component being stored in private_data on the kcontrol, which is
true for all controls added through snd_soc_add_component_controls(),
but not true for DAPM controls which often use private_data for
various internal things and call snd_soc_cnew() directly.

Thanks,
Charles

Re: Question about conversion kcontrol to component

[Kuninori Morimoto]

Hi Charles

Thank you for your reply, and sorry for my late response
(Japan was long holiday which is called as Golden Week).

> > I have noticed that we have similar functions
> > 
> > 	snd_soc_kcontrol_component()
> > 	snd_soc_dapm_kcontrol_component()
> > 
> > Both converts snd_kcontrol to snd_soc_component.
> > I wonder can we merge these ? or which we can use is case-by-case ?
> > 
> 
> I think this is case-by-case snd_soc_kcontrol_component() relies on
> the component being stored in private_data on the kcontrol, which is
> true for all controls added through snd_soc_add_component_controls(),
> but not true for DAPM controls which often use private_data for
> various internal things and call snd_soc_cnew() directly.

OK, thanks. I will investigate about this. Your reply is good hint for it.
I think we want to use same function for it.

Thank you for your help !!

Best regards
---
Kuninori Morimoto