RE: [RESEND v7 0/2] ASoC: codecs: add support for ES8389

RE: [RESEND v7 0/2] ASoC: codecs: add support for ES8389

[Zhang Yi]

> This doesn't apply:
> 
> Applying: ASoC: codecs: add support for ES8389
> error: sha1 information is lacking or useless (sound/soc/codecs/Kconfig).
> error: could not build fake ancestor
> Patch failed at 0001 ASoC: codecs: add support for ES8389
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
> broonie@finisterre:~/git/apply$ git am --abort

I'm confused as to why this happened.
I made the patch based on the following branch
https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/?h=next-20250513

Re: [RESEND v7 0/2] ASoC: codecs: add support for ES8389

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]

On Wed, May 14, 2025 at 05:02:57PM +0800, Zhang Yi wrote:

> > Applying: ASoC: codecs: add support for ES8389
> > error: sha1 information is lacking or useless (sound/soc/codecs/Kconfig).
> > error: could not build fake ancestor
> > Patch failed at 0001 ASoC: codecs: add support for ES8389

> I'm confused as to why this happened.
> I made the patch based on the following branch
> https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/?h=next-20250513

That's not my tree, that's linux-next.  MAINTAINERS shows:

SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEMENT (ASoC)
M:      Liam Girdwood <lgirdwood@gmail.com>
M:      Mark Brown <broonie@kernel.org>
L:      linux-sound@vger.kernel.org
S:      Supported
W:      http://alsa-project.org/main/index.php/ASoC
T:      git git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

and note that above git is saying it's not got a useful SHA1 in your
patch so either there's a formatting issue or it's not quite -next (the
repo I apply to has -next so would see -next commits).  For things
targetting 6.16 you want for-6.16.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: [RESEND v7 0/2] ASoC: codecs: add support for ES8389

[Zhang Yi]

> That's not my tree, that's linux-next.  MAINTAINERS shows:
> 
> SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEMENT (ASoC)
> M:      Liam Girdwood <lgirdwood@gmail.com>
> M:      Mark Brown <broonie@kernel.org>
> L:      linux-sound@vger.kernel.org
> S:      Supported
> W:      http://alsa-project.org/main/index.php/ASoC
> T:      git git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
> 
> and note that above git is saying it's not got a useful SHA1 in your
> patch so either there's a formatting issue or it's not quite -next (the
> repo I apply to has -next so would see -next commits).  For things
> targetting 6.16 you want for-6.16.

Thank you for your reply. I will check my next-branch.

[RESEND v7 0/2] ASoC: codecs: add support for ES8389

[Zhang Yi]

The driver is for codec ES8389 of everest-semi.

v7 -> v6:
          - Modify the order in the Kconfig and Makefile
          - Remove ES8390 in description of codec driver
          - Romove unused variable in the codec driver
          - Modify notation for declaring variables

v6 -> v5: add "Reviewed-by" at v6 2/2

v5 -> v4:
          - Modify kcontrol on DMIC in the codec driver
          - Modify the way to set the slot and add es8389_set_tdm_slot
           in the codec driver
          - Modify the problem ablout making the use of a MCLK depend on
           the configuration of a TDM slot in the codec driver
          - Remove the "everest,adc-slot", "everest,dac-slot" and
           "everest,dmic-enabled" in the codec driver and the yaml file,
           because they are unnecessary. 
          - Remove the "prefix_name" in the yaml file.

v4 -> v3:
          - Remove simple probe enter/exit debugs in the codec driver
          - Modify the problem about double free in i2c_probe
          - Modify the problem about coding style and wrapping
          - Modify the problem about Bindings are before the user
          - Modify the ref of "everest,adc-slot" and "everest,dac-slot"
             in the yaml file
          - Add description of "prefix_name" and "everest,dmic-enabled"
             in the yaml file

v3 -> v2: Modify the format of examples in the yaml file

v2 -> v1:
          - Remove a empty switch in the codec driver
          - Modify the format of examples in the yaml file

v1 -> v0:
          - Modify the register names in the codec driver 
          - Use yaml instead of txt to describe dts

Zhang Yi (2):
  ASoC: codecs: add support for ES8389
  ASoC: dt-bindings: Add Everest ES8389 audio CODEC

 .../bindings/sound/everest,es8389.yaml        |  50 +
 sound/soc/codecs/Kconfig                      |   7 +-
 sound/soc/codecs/Makefile                     |   2 +
 sound/soc/codecs/es8389.c                     | 962 ++++++++++++++++++
 sound/soc/codecs/es8389.h                     | 140 +++
 5 files changed, 1160 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/sound/everest,es8389.yaml
 create mode 100644 sound/soc/codecs/es8389.c
 create mode 100644 sound/soc/codecs/es8389.h

-- 
2.17.1

Re: [RESEND v7 0/2] ASoC: codecs: add support for ES8389

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

On Wed, May 14, 2025 at 11:33:25AM +0800, Zhang Yi wrote:
> The driver is for codec ES8389 of everest-semi.

This doesn't apply:

Applying: ASoC: codecs: add support for ES8389
error: sha1 information is lacking or useless (sound/soc/codecs/Kconfig).
error: could not build fake ancestor
Patch failed at 0001 ASoC: codecs: add support for ES8389
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
broonie@finisterre:~/git/apply$ git am --abort

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [RESEND v7 0/2] ASoC: codecs: add support for ES8389

[Mark Brown]

On Wed, 14 May 2025 11:33:25 +0800, Zhang Yi wrote:
> The driver is for codec ES8389 of everest-semi.
> 
> v7 -> v6:
>           - Modify the order in the Kconfig and Makefile
>           - Remove ES8390 in description of codec driver
>           - Romove unused variable in the codec driver
>           - Modify notation for declaring variables
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: codecs: add support for ES8389
      commit: dd4eb861d0521acca1b7e07683a7e90b2e01f66a
[2/2] ASoC: dt-bindings: Add Everest ES8389 audio CODEC
      commit: c8e7d528284a0bb1cd462b994c464bf31d24a0ce

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark