* [PATCH] ALSA: usb-audio: fix control pipe direction
@ 2025-10-18 17:18 Roy Vegard Ovesen
2025-10-18 18:12 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Roy Vegard Ovesen @ 2025-10-18 17:18 UTC (permalink / raw)
To: linux-sound; +Cc: Takashi Iwai, Xj
Since the requesttype has USB_DIR_OUT the pipe should be
constructed with usb_sndctrlpipe().
Signed-off-by: Roy Vegard Ovesen <roy.vegard.ovesen@gmail.com>
---
sound/usb/mixer_s1810c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/usb/mixer_s1810c.c b/sound/usb/mixer_s1810c.c
index 15960d25e748..89c652434f71 100644
--- a/sound/usb/mixer_s1810c.c
+++ b/sound/usb/mixer_s1810c.c
@@ -178,7 +178,7 @@ snd_sc1810c_get_status_field(struct usb_device *dev,
pkt_out.fields[SC1810C_STATE_F1_IDX] = SC1810C_SET_STATE_F1;
pkt_out.fields[SC1810C_STATE_F2_IDX] = SC1810C_SET_STATE_F2;
- ret = snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0),
+ ret = snd_usb_ctl_msg(dev, usb_sndctrlpipe(dev, 0),
SC1810C_SET_STATE_REQ,
SC1810C_SET_STATE_REQTYPE,
(*seqnum), 0, &pkt_out, sizeof(pkt_out));
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: usb-audio: fix control pipe direction
2025-10-18 17:18 [PATCH] ALSA: usb-audio: fix control pipe direction Roy Vegard Ovesen
@ 2025-10-18 18:12 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2025-10-18 18:12 UTC (permalink / raw)
To: Roy Vegard Ovesen; +Cc: linux-sound, Takashi Iwai, Xj
On Sat, 18 Oct 2025 19:18:22 +0200,
Roy Vegard Ovesen wrote:
>
> Since the requesttype has USB_DIR_OUT the pipe should be
> constructed with usb_sndctrlpipe().
>
> Signed-off-by: Roy Vegard Ovesen <roy.vegard.ovesen@gmail.com>
Thanks, applied now with the missing Fixes tag.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-18 18:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-18 17:18 [PATCH] ALSA: usb-audio: fix control pipe direction Roy Vegard Ovesen
2025-10-18 18:12 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox