From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>
Cc: broonie@kernel.org, tiwai@suse.com, perex@perex.cz,
amade@asmblr.net, linux-sound@vger.kernel.org
Subject: Re: [PATCH 6/6] ASoC: Intel: catpt: Drop catpt_runtime_resume()
Date: Mon, 24 Nov 2025 16:37:56 +0200 [thread overview]
Message-ID: <aSRtxKLlbc1FomOL@smile.fi.intel.com> (raw)
In-Reply-To: <20251121114331.3841335-7-cezary.rojewski@intel.com>
On Fri, Nov 21, 2025 at 12:43:31PM +0100, Cezary Rojewski wrote:
> The function provides no value over catpt_resume(), use the latter
> directly.
This makes code understanding a bit harder in my opinion. I would not apply
this patch.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-11-24 14:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 11:43 [PATCH 0/6] ASoC: Intel: catpt: Round of fixes and PM changes Cezary Rojewski
2025-11-21 11:43 ` [PATCH 1/6] ASoC: Intel: catpt: Fix offset checks Cezary Rojewski
2025-11-24 14:31 ` Andy Shevchenko
2025-11-24 18:20 ` Cezary Rojewski
2025-11-24 19:05 ` Andy Shevchenko
2025-11-24 19:06 ` Andy Shevchenko
2025-11-25 11:31 ` Cezary Rojewski
2025-11-25 18:24 ` Andy Shevchenko
2025-11-25 18:26 ` Andy Shevchenko
2025-11-21 11:43 ` [PATCH 2/6] ASoC: Intel: catpt: Fix error path in hw_params() Cezary Rojewski
2025-11-21 11:43 ` [PATCH 3/6] ASoC: Intel: catpt: Fix probing order of driver components Cezary Rojewski
2025-11-21 11:43 ` [PATCH 4/6] ASoC: Intel: catpt: Do not ignore errors on runtime resume Cezary Rojewski
2025-11-21 11:43 ` [PATCH 5/6] ASoC: Intel: catpt: Do not block the system from suspending Cezary Rojewski
2025-11-24 14:42 ` Andy Shevchenko
2025-11-24 18:05 ` Cezary Rojewski
2025-11-24 19:07 ` Andy Shevchenko
2025-11-21 11:43 ` [PATCH 6/6] ASoC: Intel: catpt: Drop catpt_runtime_resume() Cezary Rojewski
2025-11-24 14:37 ` Andy Shevchenko [this message]
2025-11-24 18:06 ` Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSRtxKLlbc1FomOL@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=amade@asmblr.net \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox