Re: [PATCH 5/6] ASoC: Intel: catpt: Do not block the system from suspending

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Mon, Nov 24, 2025 at 07:05:55PM +0100, Cezary Rojewski wrote:
> On 2025-11-24 3:42 PM, Andy Shevchenko wrote:
> > On Fri, Nov 21, 2025 at 12:43:30PM +0100, Cezary Rojewski wrote:

...

> > > +/* Do not block the system from suspending, recover on resume() if needed. */
> > > +static int catpt_suspend(struct device *dev)
> > > +{
> > > +	__catpt_suspend(dev);
> > 
> > Can we use catpt_do_suspend() name? Or something with a better suffix?
> > 
> > Wouldn't be useful to have some debug message to be printed in case of failure?
> > 
> > 	ret = catpt_do_suspend(dev);
> > 	if (ret)
> > 		dev_dbg(dev, ..., ret);
> > 
> > ?
> 
> No problem renaming the function in v2. As for the debug print,
> __catpt_suspend/catpt_do_suspend() would dump enough information already. If
> I get failure from powering up DRAM/IRAM banks or an IPC failure, additional
> "failed" message on top won't add anything useful.

Okay, then no need to add a noise, indeed.

> > > +	return 0;
> > > +}

-- 
With Best Regards,
Andy Shevchenko