Re: [PATCH 5/7] ASoC: SDCA: Add basic system suspend support

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Wed, Dec 10, 2025 at 02:43:17PM +0000, Charles Keepax wrote:
> On Tue, Dec 09, 2025 at 12:11:27PM +0000, Pierre-Louis Bossart wrote:
> > On 11/25/25 15:21, Charles Keepax wrote:
> > > +	if (drv->suspended) {
> > > +		sdca_irq_enable(drv->function, drv->core->irq_info, true);
> > > +		sdca_irq_enable(drv->function, drv->core->irq_info, false);
> > 
> > and a comment here wouldn't hurt, not sure about the side/racy
> > effects of turning the interrupt on before turning it off?
> 
> This is perhaps a little misleading the last parameter here is an
> early flag not an enable/disable. I could perhaps replace that
> with some defines rather than a bool to keep the calls more
> self-documenting.

Look at this again I think best would just be to add an _early
version of the function that is what we did for the populate
functions so it would keep the API more consistent. I will update
for a v2 once the merge window closes.

Thanks,
Charles