Re: [PATCH 1/7] ASoC: SDCA: Factor out jack handling into new c file

[Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>]

> +	switch (val) {
> +	case SDCA_DETECTED_MODE_DETECTION_IN_PROGRESS:
> +	case SDCA_DETECTED_MODE_JACK_UNKNOWN:
> +		reg = SDW_SDCA_CTL(interrupt->function->desc->adr,
> +				   interrupt->entity->id,
> +				   SDCA_CTL_GE_SELECTED_MODE, 0);
> +
> +		/*
> +		 * Selected mode is not normally marked as volatile register
> +		 * (RW), but here force a read from the hardware. If the
> +		 * detected mode is unknown we need to see what the device
> +		 * selected as a "safe" option.
> +		 */
> +		regcache_drop_region(interrupt->function_regmap, reg, reg);
> +
> +		ret = regmap_read(interrupt->function_regmap, reg, &val);
> +		if (ret) {
> +			dev_err(dev, "failed to re-check selected mode: %d\n", ret);
> +			return ret;
> +		}

The detected_mode is reported by hardware and copied into the selected_mode, but that's not the end of it.
We should capture with at least a comment that the intent of the SDCA design was to let the user or additional vendor-specific override the selected mode. If/when we have to deal with the complicated multi-jack topologies it'll be required.