Re: [PATCH] ASoC: sdw_utils: cs42l43: Enable Headphone pin for LINEOUT jack type

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Tue, Jan 13, 2026 at 01:44:02AM -0700, Cole Leavitt wrote:
> The CS42L43 codec's load detection can return different impedance values
> that map to either HEADPHONE or LINEOUT jack types. However, the
> soc_jack_pins array only maps SND_JACK_HEADPHONE to the "Headphone" DAPM
> pin, not SND_JACK_LINEOUT.
> 
> When headphones are detected with an impedance that maps to LINEOUT
> (such as impedance value 0x2), the driver reports SND_JACK_LINEOUT.
> Since this doesn't match the jack pin mask, the "Headphone" DAPM pin
> is not activated, and no audio is routed to the headphone outputs.
> 
> Fix by adding SND_JACK_LINEOUT to the Headphone pin mask, so that both
> headphone and line-out detection properly enable the headphone output
> path.
> 
> This fixes no audio output on devices like the Lenovo ThinkPad P16 Gen 3
> where headphones are detected with LINEOUT impedance.
> 
> Fixes: 45b8e93bd0c7 ("ASoC: sdw_utils: Add helper for soc_sdw_cs42l43")
> Signed-off-by: Cole Leavitt <cole@unwrap.rs>
> ---
>  sound/soc/sdw_utils/soc_sdw_cs42l43.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sdw_utils/soc_sdw_cs42l43.c b/sound/soc/sdw_utils/soc_sdw_cs42l43.c
> index 4c954501e500..2685ff4f0932 100644
> --- a/sound/soc/sdw_utils/soc_sdw_cs42l43.c
> +++ b/sound/soc/sdw_utils/soc_sdw_cs42l43.c
> @@ -44,7 +44,7 @@ static const struct snd_soc_dapm_route cs42l43_dmic_map[] = {
>  static struct snd_soc_jack_pin soc_jack_pins[] = {
>  	{
>  		.pin    = "Headphone",
> -		.mask   = SND_JACK_HEADPHONE,
> +		.mask   = SND_JACK_HEADPHONE | SND_JACK_LINEOUT,

This looks pretty reasonable we don't have any intention to do
different routing for headphone/lineout:

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles