From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Cole Leavitt <cole@unwrap.rs>
Cc: linux-sound@vger.kernel.org, sbinding@opensource.cirrus.com,
broonie@kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH] ASoC: cs42l43: Fix headphone volume control overflow at 100%
Date: Thu, 15 Jan 2026 09:42:15 +0000 [thread overview]
Message-ID: <aWi2d6XqgvyGPi6h@opensource.cirrus.com> (raw)
In-Reply-To: <20260114213829.15456-1-cole@unwrap.rs>
On Wed, Jan 14, 2026 at 02:38:29PM -0700, Cole Leavitt wrote:
> The headphone digital volume control is defined with:
> SOC_DOUBLE_SX_TLV(..., 0x11B, 229, ...)
>
> Where 0x11B (283) is the minimum register value and 229 is the number of
> steps. This means the maximum register value is 283 + 229 = 512 (0x200).
>
> However, the register field is only 9 bits wide (mask 0x1FF, max 511).
> When the volume is set to 100%, the computed register value of 512
> overflows and wraps to 0, causing the volume to suddenly drop to minimum.
Is this actually based off real world testing?
Thanks,
Charles
prev parent reply other threads:[~2026-01-15 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 21:38 [PATCH] ASoC: cs42l43: Fix headphone volume control overflow at 100% Cole Leavitt
2026-01-15 9:42 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWi2d6XqgvyGPi6h@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=cole@unwrap.rs \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=sbinding@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox