Re: [PATCH v3 19/23] ASoC: Intel: Replace playback/capture_only to playback/capture_assertion

[Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>]

On 4/18/24 06:19, Amadeusz Sławiński wrote:
> On 4/18/2024 6:15 AM, Kuninori Morimoto wrote:
>> soc_get_playback_capture() is now handling DPCM and normal
>> comprehensively for playback/capture stream in same code.
>> This patch converts xxx_only flag to xxx_assertion.
>>
>> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>> ---
>>   sound/soc/intel/boards/bdw-rt5677.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/intel/boards/bdw-rt5677.c
>> b/sound/soc/intel/boards/bdw-rt5677.c
>> index 54e3c5d3c251..9170b1d509e2 100644
>> --- a/sound/soc/intel/boards/bdw-rt5677.c
>> +++ b/sound/soc/intel/boards/bdw-rt5677.c
>> @@ -339,7 +339,7 @@ static struct snd_soc_dai_link bdw_rt5677_dais[] = {
>>       {
>>           .name = "Codec DSP",
>>           .stream_name = "Wake on Voice",
>> -        .capture_only = 1,
>> +        .capture_assertion = 1,
>>           .ops = &bdw_rt5677_dsp_ops,
>>           SND_SOC_DAILINK_REG(dsp),
>>       },
> 
> Should this have been part of patch 8?

Patch 8 deals with the following changes

-		.dpcm_playback = 1,
-		.dpcm_capture = 1,
+		.playback_assertion = 1,
+		.capture_assertion = 1,

This case is about

> -        .capture_only = 1,
> +        .capture_assertion = 1,

I think it's good to make this change separately.