Re: [PATCH v15 3/6] ASoC: es9356-sdca: Add ES9356 SDCA driver

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Wed, May 20, 2026 at 04:14:20PM -0700, Nathan Chancellor wrote:
> On Tue, May 19, 2026 at 05:30:41PM +0100, Mark Brown wrote:
> > On Tue, May 19, 2026 at 09:23:52AM -0700, Nathan Chancellor wrote:
> > > Yeah, I realized shortly after sending that suggestion through testing
> > > that it would error during the Kconfig stage due to a recursive
> > > dependency issue. However, CONFIG_SND_SOC_SDCA is not a user selectable
> > > symbol and I only see it selected through
> > 
> > >   CONFIG_SND_SOC_ACPI_INTEL_MATCH -> CONFIG_SND_SOC_ACPI_INTEL_SDCA_QUIRKS
> > 
> > > so is it expected that users have to enable a driver that selects
> > > CONFIG_SND_SOC_ACPI_INTEL_MATCH to get CONFIG_SND_SOC_SDCA?
> > 
> > That seems off, it's not like SoundWire is Intel or even x86 specific.
> > I would expect either it should be user selectable or the drivers using
> > it should select it.  Given that it's a class driver that probably means
> > user selectable I think, some devices might need no extra support?

Yeah currently the class driver itself is user-selectable but
doesn't make much sense to have SDCA selected through the host
stuff.

> Yeah, just turning it into a user selectable symbol like
> 
> diff --git a/sound/soc/sdca/Kconfig b/sound/soc/sdca/Kconfig
> index 87ab2895096c..4c0dcb9ff3b9 100644
> --- a/sound/soc/sdca/Kconfig
> +++ b/sound/soc/sdca/Kconfig
> @@ -2,7 +2,7 @@
>  menu "SoundWire (SDCA)"
>  
>  config SND_SOC_SDCA
> -	tristate
> +	tristate "SDCA core support"
>  	depends on ACPI
>  	select AUXILIARY_BUS
>  	help
> 
> --
> 
> appears to work for me, in combination with adding
> 
>   depends on SND_SOC_SDCA
> 
> to the symbol for this driver.

I certainly don't object to SDCA being user selectable, although
yeah in my head drivers needing SDCA selecting it is probably the
cleanest.

I think a lot of this stems for the slight weirdness around SDCA
and SoundWire quirks, there is a weird interaction where
SoundWire calls some SDCA functions really early to do some quirk
stuff (see sdw_slave_add), but that makes it really easy to end up
with weird dependencies, because obviously SDCA will call
SoundWire.

Thanks,
Charles