* [PATCH] ASoC: fsl_mqs: Add DAPM output widgets for MQS_L/MQS_R pins
@ 2026-08-20 2:14 Chancel Liu
2026-08-20 13:47 ` Alvin Šipraga
2026-08-20 15:48 ` Frank Li
0 siblings, 2 replies; 3+ messages in thread
From: Chancel Liu @ 2026-08-20 2:14 UTC (permalink / raw)
To: shengjiu.wang, Xiubo.Lee, festevam, nicoleotsuka, lgirdwood,
broonie, perex, tiwai
Cc: Frank.Li, linuxppc-dev, linux-sound, linux-kernel
From: Chancel Liu <chancel.liu@nxp.com>
Provide DAPM output widgets for the MQS_L/MQS_R pins and route them
from the "Playback" stream. This allows external amplifiers connected
to the MQS outputs to be properly linked into the DAPM graph, so their
power state can follow the playback stream.
Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
---
sound/soc/fsl/fsl_mqs.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/sound/soc/fsl/fsl_mqs.c b/sound/soc/fsl/fsl_mqs.c
index 901f840df904..5b00488253bb 100644
--- a/sound/soc/fsl/fsl_mqs.c
+++ b/sound/soc/fsl/fsl_mqs.c
@@ -183,7 +183,21 @@ static void fsl_mqs_shutdown(struct snd_pcm_substream *substream,
mqs_priv->soc->en_mask, 0);
}
+static const struct snd_soc_dapm_widget fsl_mqs_dapm_widgets[] = {
+ SND_SOC_DAPM_OUTPUT("MQS_L"),
+ SND_SOC_DAPM_OUTPUT("MQS_R"),
+};
+
+static const struct snd_soc_dapm_route fsl_mqs_dapm_routes[] = {
+ { "MQS_L", NULL, "Playback" },
+ { "MQS_R", NULL, "Playback" },
+};
+
static const struct snd_soc_component_driver soc_codec_fsl_mqs = {
+ .dapm_widgets = fsl_mqs_dapm_widgets,
+ .num_dapm_widgets = ARRAY_SIZE(fsl_mqs_dapm_widgets),
+ .dapm_routes = fsl_mqs_dapm_routes,
+ .num_dapm_routes = ARRAY_SIZE(fsl_mqs_dapm_routes),
.idle_bias_on = 1,
};
--
2.50.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: fsl_mqs: Add DAPM output widgets for MQS_L/MQS_R pins
2026-08-20 2:14 [PATCH] ASoC: fsl_mqs: Add DAPM output widgets for MQS_L/MQS_R pins Chancel Liu
@ 2026-08-20 13:47 ` Alvin Šipraga
2026-08-20 15:48 ` Frank Li
1 sibling, 0 replies; 3+ messages in thread
From: Alvin Šipraga @ 2026-08-20 13:47 UTC (permalink / raw)
To: Chancel Liu
Cc: shengjiu.wang, Xiubo.Lee, festevam, nicoleotsuka, lgirdwood,
broonie, perex, tiwai, Frank.Li, linuxppc-dev, linux-sound,
linux-kernel
On Thu, Aug 20, 2026 at 11:14:53AM +0900, Chancel Liu wrote:
> From: Chancel Liu <chancel.liu@nxp.com>
>
> Provide DAPM output widgets for the MQS_L/MQS_R pins and route them
> from the "Playback" stream. This allows external amplifiers connected
> to the MQS outputs to be properly linked into the DAPM graph, so their
> power state can follow the playback stream.
>
> Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
> ---
> sound/soc/fsl/fsl_mqs.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
Reviewed-by: Alvin Šipraga <alvin.sipraga@analog.com>
> diff --git a/sound/soc/fsl/fsl_mqs.c b/sound/soc/fsl/fsl_mqs.c
> index 901f840df904..5b00488253bb 100644
> --- a/sound/soc/fsl/fsl_mqs.c
> +++ b/sound/soc/fsl/fsl_mqs.c
> @@ -183,7 +183,21 @@ static void fsl_mqs_shutdown(struct snd_pcm_substream *substream,
> mqs_priv->soc->en_mask, 0);
> }
>
> +static const struct snd_soc_dapm_widget fsl_mqs_dapm_widgets[] = {
> + SND_SOC_DAPM_OUTPUT("MQS_L"),
> + SND_SOC_DAPM_OUTPUT("MQS_R"),
> +};
> +
> +static const struct snd_soc_dapm_route fsl_mqs_dapm_routes[] = {
> + { "MQS_L", NULL, "Playback" },
> + { "MQS_R", NULL, "Playback" },
> +};
> +
> static const struct snd_soc_component_driver soc_codec_fsl_mqs = {
> + .dapm_widgets = fsl_mqs_dapm_widgets,
> + .num_dapm_widgets = ARRAY_SIZE(fsl_mqs_dapm_widgets),
> + .dapm_routes = fsl_mqs_dapm_routes,
> + .num_dapm_routes = ARRAY_SIZE(fsl_mqs_dapm_routes),
> .idle_bias_on = 1,
> };
>
> --
> 2.50.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: fsl_mqs: Add DAPM output widgets for MQS_L/MQS_R pins
2026-08-20 2:14 [PATCH] ASoC: fsl_mqs: Add DAPM output widgets for MQS_L/MQS_R pins Chancel Liu
2026-08-20 13:47 ` Alvin Šipraga
@ 2026-08-20 15:48 ` Frank Li
1 sibling, 0 replies; 3+ messages in thread
From: Frank Li @ 2026-08-20 15:48 UTC (permalink / raw)
To: Chancel Liu
Cc: shengjiu.wang, Xiubo.Lee, festevam, nicoleotsuka, lgirdwood,
broonie, perex, tiwai, Frank.Li, linuxppc-dev, linux-sound,
linux-kernel
On Thu, Aug 20, 2026 at 11:14:53AM +0900, Chancel Liu wrote:
> From: Chancel Liu <chancel.liu@nxp.com>
>
> Provide DAPM output widgets for the MQS_L/MQS_R pins and route them
> from the "Playback" stream. This allows external amplifiers connected
> to the MQS outputs to be properly linked into the DAPM graph, so their
> power state can follow the playback stream.
>
> Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> sound/soc/fsl/fsl_mqs.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/sound/soc/fsl/fsl_mqs.c b/sound/soc/fsl/fsl_mqs.c
> index 901f840df904..5b00488253bb 100644
> --- a/sound/soc/fsl/fsl_mqs.c
> +++ b/sound/soc/fsl/fsl_mqs.c
> @@ -183,7 +183,21 @@ static void fsl_mqs_shutdown(struct snd_pcm_substream *substream,
> mqs_priv->soc->en_mask, 0);
> }
>
> +static const struct snd_soc_dapm_widget fsl_mqs_dapm_widgets[] = {
> + SND_SOC_DAPM_OUTPUT("MQS_L"),
> + SND_SOC_DAPM_OUTPUT("MQS_R"),
> +};
> +
> +static const struct snd_soc_dapm_route fsl_mqs_dapm_routes[] = {
> + { "MQS_L", NULL, "Playback" },
> + { "MQS_R", NULL, "Playback" },
> +};
> +
> static const struct snd_soc_component_driver soc_codec_fsl_mqs = {
> + .dapm_widgets = fsl_mqs_dapm_widgets,
> + .num_dapm_widgets = ARRAY_SIZE(fsl_mqs_dapm_widgets),
> + .dapm_routes = fsl_mqs_dapm_routes,
> + .num_dapm_routes = ARRAY_SIZE(fsl_mqs_dapm_routes),
> .idle_bias_on = 1,
> };
>
> --
> 2.50.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-08-20 15:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-20 2:14 [PATCH] ASoC: fsl_mqs: Add DAPM output widgets for MQS_L/MQS_R pins Chancel Liu
2026-08-20 13:47 ` Alvin Šipraga
2026-08-20 15:48 ` Frank Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox