Re: [PATCH 12/15] ASoC: soc-card: move snd_soc_card_bind_call()

["Alvin Šipraga" <alvin.sipraga@analog.com>]

On Wed, Oct 28, 2026 at 03:03:50AM +0000, Kuninori Morimoto wrote:
> struct snd_soc_card will be capsuled soon, its member will not be
> able to access from non soc-card.c.
> 
> It has too many local function dependencies.
> This patch uses temporary funciton define at soc-internal.h. It will be
> removed all funciton were moved.
> 
> It renames function name
> -	call_soc_bind_card()
> -	snd_soc_bind_card()
> -	snd_soc_unbind_card()
> +	snd_soc_card_bind_call()
> +	snd_soc_card_bind()
> +	snd_soc_card_unbind()
> 
> Below function is used on above functions. Add them at soc-internal.h
> +	snd_soc_flush_all_delayed_work()
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  sound/soc/soc-card.c     | 411 +++++++++++++++++++++++++++++++++++++-
>  sound/soc/soc-core.c     | 419 +--------------------------------------
>  sound/soc/soc-internal.h |   8 +
>  3 files changed, 422 insertions(+), 416 deletions(-)
> 
> diff --git a/sound/soc/soc-card.c b/sound/soc/soc-card.c
> index c64c9d425bcf9..72b40f842bd43 100644
> --- a/sound/soc/soc-card.c
> +++ b/sound/soc/soc-card.c
> @@ -9,12 +9,16 @@
>  #include <linux/debugfs.h>
>  #include <linux/dmi.h>
>  #include <linux/lockdep.h>
> +#include <linux/pinctrl/consumer.h>
>  #include <linux/rwsem.h>
> +#include <sound/initval.h>
>  #include <sound/soc.h>
>  #include <sound/soc-link.h>
>  #include <sound/jack.h>
>  #include "soc-internal.h"
>  
> +LIST_HEAD(unbind_card_list);
> +
>  #define soc_card_ret(dai, ret) _soc_card_ret(dai, __func__, ret)
>  static inline int _soc_card_ret(struct snd_soc_card *card,
>  				const char *func, int ret)
> @@ -465,6 +469,157 @@ int snd_soc_card_set_dmi_name(struct snd_soc_card *card)
>  }
>  #endif /* CONFIG_DMI */
>  
> +static void soc_card_check_tplg_fes(struct snd_soc_card *card)

Don't you want the snd_ prefix here too, since you're renaming anyway?

> +{
> +	struct snd_soc_component *component;
> +	struct snd_soc_dai_link *dai_link;
> +	int i;
> +
> +	for_each_component(component) {

[...]

> +
> +#define soc_card_setup_name(card, name, name1, name2)			\
> +	__soc_card_setup_name(card, name, sizeof(name), name1, name2)
> +static void __soc_card_setup_name(struct snd_soc_card *card,
> +				  char *name, int len,
> +				  const char *name1, const char *name2)

snd_ prefix here too?

> +{
> +	const char *src = name1 ? name1 : name2;
> +	int i;
> +
> +	snprintf(name, len, "%s", src);
> +
> +	if (name != card->snd_card->driver)
> +		return;
> +

[...]

Kind regards,
Alvin