Re: [PATCH 14/15] ASoC: soc-card: make unbind_card_list static

["Alvin Šipraga" <alvin.sipraga@analog.com>]

On Wed, Oct 28, 2026 at 03:03:57AM +0000, Kuninori Morimoto wrote:
> struct snd_soc_card will be capsuled soon, its member will not be
> able to access from non soc-card.c.
> 
> Update snd_soc_card_unbind() and makes unbind_card_list static in
> soc-card.c
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  sound/soc/soc-card.c     | 10 ++++++++--
>  sound/soc/soc-core.c     | 12 +++---------
>  sound/soc/soc-internal.h |  3 +--
>  3 files changed, 12 insertions(+), 13 deletions(-)
> 
> diff --git a/sound/soc/soc-card.c b/sound/soc/soc-card.c
> index f6ff99bf8a601..959b56be0eedf 100644
> --- a/sound/soc/soc-card.c
> +++ b/sound/soc/soc-card.c
> @@ -17,7 +17,7 @@
>  #include <sound/jack.h>
>  #include "soc-internal.h"
>  
> -LIST_HEAD(unbind_card_list);
> +static LIST_HEAD(unbind_card_list);

A bit irrelevant to capsuling, but I think it would make more sense for
the list to be called unbound_card_list. It would make this part more
understandable:

int snd_soc_component_register(struct snd_soc_component *component,
			       struct snd_soc_dai_driver *dai_drv,
			       int num_dai)
{
	struct snd_soc_card *card, *c;

	...

	/* Alvin's comment: retry binding any unbound cards in case this
	 * component completes them
	 */
	list_for_each_entry_safe(card, c, &unbind_card_list, list)
		snd_soc_card_bind_call(card);

	...
}

But feel free to ignore :)

Kind regards,
Alvin