From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Olivier Louvignes <olivier@mgcrea.io>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
linux-sound@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH v3] ASoC: cs43130: Power the playback path down when the stream closes
Date: Mon, 9 Nov 2026 09:58:05 +0000 [thread overview]
Message-ID: <avGZLYM7b8EOt5p+@opensource.cirrus.com> (raw)
In-Reply-To: <20261106214230.17417-1-olivier@mgcrea.io>
On Fri, Nov 06, 2026 at 10:42:30PM +0100, Olivier Louvignes wrote:
> With use_pmdown_time set, DAPM keeps the playback path powered and
> unmuted for pmdown_time after a stream closes, and the DAC plays
> whatever its serial port carries meanwhile: on a HiBy R1 (CS43131 on an
> Ingenic X1600 I2S controller), white noise once a stream stops. Drop it
> from both component drivers, so that the path powers down as the stream
> closes.
>
> Suggested-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> Signed-off-by: Olivier Louvignes <olivier@mgcrea.io>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2026-11-09 9:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 21:42 [PATCH v3] ASoC: cs43130: Power the playback path down when the stream closes Olivier Louvignes
2026-11-09 9:58 ` Charles Keepax [this message]
2026-11-09 12:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avGZLYM7b8EOt5p+@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=olivier@mgcrea.io \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).