[PATCH v3] ASoC: cs43130: Power the playback path down when the stream closes

[PATCH v3] ASoC: cs43130: Power the playback path down when the stream closes

[Olivier Louvignes]

With use_pmdown_time set, DAPM keeps the playback path powered and
unmuted for pmdown_time after a stream closes, and the DAC plays
whatever its serial port carries meanwhile: on a HiBy R1 (CS43131 on an
Ingenic X1600 I2S controller), white noise once a stream stops. Drop it
from both component drivers, so that the path powers down as the stream
closes.

Suggested-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Olivier Louvignes <olivier@mgcrea.io>
---
Changes in v3, now a single patch since 1/2 was applied:
- Drop use_pmdown_time instead of adding a mute_stream() op (Charles).
  Tested on the R1: the codec's bias level is back to standby within
  0.5 s of the stream closing, a stream restarts in 0.08 s, and the
  noise after a stop is gone. A faint pop as the path powers down
  remains, fainter and rarer than with v2's mute.

v2: https://lore.kernel.org/r/20261023202941.87999-1-olivier@mgcrea.io

 sound/soc/codecs/cs43130.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sound/soc/codecs/cs43130.c b/sound/soc/codecs/cs43130.c
index 7fb23522f081..4db57758f897 100644
--- a/sound/soc/codecs/cs43130.c
+++ b/sound/soc/codecs/cs43130.c
@@ -2428,7 +2428,6 @@ static const struct snd_soc_component_driver soc_component_dev_cs43130_digital =
 	.set_sysclk		= cs43130_component_set_sysclk,
 	.set_pll		= cs43130_set_pll,
 	.idle_bias_on		= 1,
-	.use_pmdown_time	= 1,
 	.endianness		= 1,
 	/* Don't take into account the ending analog widgets and routes */
 	.dapm_widgets		= hp_widgets,
@@ -2444,7 +2443,6 @@ static const struct snd_soc_component_driver soc_component_dev_cs43130_analog =
 	.set_sysclk		= cs43130_component_set_sysclk,
 	.set_pll		= cs43130_set_pll,
 	.idle_bias_on		= 1,
-	.use_pmdown_time	= 1,
 	.endianness		= 1,
 	.dapm_widgets		= hp_widgets,
 	.num_dapm_widgets	= ARRAY_SIZE(hp_widgets),

base-commit: b72f6bb43dec5e89c26adf049056e24e85e5e65e
-- 
2.39.5

Re: [PATCH v3] ASoC: cs43130: Power the playback path down when the stream closes

[Charles Keepax]

On Fri, Nov 06, 2026 at 10:42:30PM +0100, Olivier Louvignes wrote:
> With use_pmdown_time set, DAPM keeps the playback path powered and
> unmuted for pmdown_time after a stream closes, and the DAC plays
> whatever its serial port carries meanwhile: on a HiBy R1 (CS43131 on an
> Ingenic X1600 I2S controller), white noise once a stream stops. Drop it
> from both component drivers, so that the path powers down as the stream
> closes.
> 
> Suggested-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> Signed-off-by: Olivier Louvignes <olivier@mgcrea.io>
> ---

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

Re: [PATCH v3] ASoC: cs43130: Power the playback path down when the stream closes

[Mark Brown]

On Fri, 06 Nov 2026 22:42:30 +0100, Olivier Louvignes wrote:
> ASoC: cs43130: Power the playback path down when the stream closes

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.4

Thanks!

[1/1] ASoC: cs43130: Power the playback path down when the stream closes
      https://git.kernel.org/broonie/sound/c/ef53f23c065d

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark