From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: Jaroslav Kysela <perex@perex.cz>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>
Cc: linux-sound@vger.kernel.org
Subject: Re: [PATCH] ASoC: core: Change device numbering
Date: Tue, 11 Feb 2025 16:12:10 +0100 [thread overview]
Message-ID: <b0b30196-f985-433f-a3ce-0e7b4f9981fb@linux.intel.com> (raw)
In-Reply-To: <1fb3d3d9-00f7-4833-afff-7c5c66999752@perex.cz>
>>
>> Well, those can be set to something better, it's just that ASoC defaults
>> to DMI if there is no longname provided. So if you have any suggestions,
>> we can do it while also changing card names.
>> But do note that it allows for differentiating between different
>> machines using same card in case we need to do something custom for UCM
>> on one of them:
>> 2680
>> access("/usr/share/alsa/ucm2/conf.d/avs_hdaudio/LENOVO-20KH006LPB-
>> ThinkPadX1Carbon6th.conf",
>> R_OK) = -1 ENOENT (No such file or directory)
>> 2680 access("/usr/share/alsa/ucm2/conf.d/avs_hdaudio/avs_hdaudio.conf",
>> R_OK) = -1 ENOENT (No such file or directory)
>> so while not pretty I'm not sure if we can do any better, without
>> breaking above possibility. And in most cases UCM based on driver name
>> should be enough, which looks pretty enough.
>
> UCM can do DMI matching itself now like (copied from acp5x.conf):
>
> ....
> If.jupiter {
> Condition {
> Type String
> String1 "Jupiter"
> String2 "${sys:devices/virtual/dmi/id/product_name}"
> }
> True {
> ...
> ....
>
> The long name path lookup is a relict from the past. ASoC core just
> duplicates information which can be already obtained in the user space.
> I'm going to rewrite the machine specific links and use the UCM like
> matching here. With this, we can turn long name lookups in /usr/share/
> alsa/ucm2/ucm.conf off.
Oh, that's nice, should I then also set longname = shortname for our
cards? I would like to avoid a need to change things again in this area
in the future ;)
next prev parent reply other threads:[~2025-02-11 15:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 14:44 [PATCH] ASoC: core: Change device numbering Amadeusz Sławiński
2025-01-27 14:45 ` Amadeusz Sławiński
2025-01-27 14:54 ` Jaroslav Kysela
2025-01-29 9:25 ` Cezary Rojewski
2025-01-29 14:51 ` Amadeusz Sławiński
2025-01-31 9:03 ` Jaroslav Kysela
2025-01-31 12:41 ` Amadeusz Sławiński
2025-01-31 16:18 ` Jaroslav Kysela
2025-02-11 10:53 ` Amadeusz Sławiński
2025-02-11 13:30 ` Jaroslav Kysela
2025-02-11 13:33 ` Takashi Iwai
2025-02-11 13:56 ` Amadeusz Sławiński
2025-02-11 14:50 ` Jaroslav Kysela
2025-02-11 15:12 ` Amadeusz Sławiński [this message]
2025-02-12 13:39 ` Jaroslav Kysela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0b30196-f985-433f-a3ce-0e7b4f9981fb@linux.intel.com \
--to=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox