* Re: [PATCH v3 1/2] ASoC: SOF: amd: Move signed_fw_image to struct acp_quirk_entry
2024-02-20 20:16 ` [PATCH v3 1/2] ASoC: SOF: amd: Move signed_fw_image to struct acp_quirk_entry Cristian Ciocaltea
@ 2024-02-21 6:14 ` Venkata Prasad Potturu
2024-02-21 8:55 ` Cristian Ciocaltea
2024-02-21 7:28 ` Venkata Prasad Potturu
2024-02-21 9:35 ` AngeloGioacchino Del Regno
2 siblings, 1 reply; 13+ messages in thread
From: Venkata Prasad Potturu @ 2024-02-21 6:14 UTC (permalink / raw)
To: Cristian Ciocaltea, Pierre-Louis Bossart, Liam Girdwood,
Peter Ujfalusi, Bard Liao, Ranjani Sridharan, Daniel Baluta,
Kai Vehmanen, Mark Brown, Jaroslav Kysela, Takashi Iwai
Cc: sound-open-firmware, linux-sound, linux-kernel, kernel
On 2/21/24 01:46, Cristian Ciocaltea wrote:
> The signed_fw_image member of struct sof_amd_acp_desc is used to enable
> signed firmware support in the driver via the acp_sof_quirk_table.
>
> In preparation to support additional use cases of the quirk table (i.e.
> adding new flags), move signed_fw_image to a new struct acp_quirk_entry
> and update all references to it accordingly.
>
> No functional changes intended.
If there are no new flags currently being used in this patch, and also
no functional changes added, in this case this patch is really required?
Also please use scripts/get_maintainer.pl in CC while sending patches,
then only
maintainers get notified your changes.
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
> sound/soc/sof/amd/acp-loader.c | 2 +-
> sound/soc/sof/amd/acp.c | 47 ++++++++++++++++++----------------
> sound/soc/sof/amd/acp.h | 6 ++++-
> sound/soc/sof/amd/vangogh.c | 9 +++++--
> 4 files changed, 38 insertions(+), 26 deletions(-)
>
> diff --git a/sound/soc/sof/amd/acp-loader.c b/sound/soc/sof/amd/acp-loader.c
> index d2d21478399e..aad904839b81 100644
> --- a/sound/soc/sof/amd/acp-loader.c
> +++ b/sound/soc/sof/amd/acp-loader.c
> @@ -173,7 +173,7 @@ int acp_dsp_pre_fw_run(struct snd_sof_dev *sdev)
>
> adata = sdev->pdata->hw_pdata;
>
> - if (adata->signed_fw_image)
> + if (adata->quirks && adata->quirks->signed_fw_image)
> size_fw = adata->fw_bin_size - ACP_FIRMWARE_SIGNATURE;
> else
> size_fw = adata->fw_bin_size;
> diff --git a/sound/soc/sof/amd/acp.c b/sound/soc/sof/amd/acp.c
> index 9b3c26210db3..9d9197fa83ed 100644
> --- a/sound/soc/sof/amd/acp.c
> +++ b/sound/soc/sof/amd/acp.c
> @@ -20,12 +20,14 @@
> #include "acp.h"
> #include "acp-dsp-offset.h"
>
> -#define SECURED_FIRMWARE 1
> -
> static bool enable_fw_debug;
> module_param(enable_fw_debug, bool, 0444);
> MODULE_PARM_DESC(enable_fw_debug, "Enable Firmware debug");
>
> +static struct acp_quirk_entry quirk_valve_galileo = {
> + .signed_fw_image = true,
> +};
> +
> const struct dmi_system_id acp_sof_quirk_table[] = {
> {
> /* Steam Deck OLED device */
> @@ -33,7 +35,7 @@ const struct dmi_system_id acp_sof_quirk_table[] = {
> DMI_MATCH(DMI_SYS_VENDOR, "Valve"),
> DMI_MATCH(DMI_PRODUCT_NAME, "Galileo"),
> },
> - .driver_data = (void *)SECURED_FIRMWARE,
> + .driver_data = &quirk_valve_galileo,
> },
> {}
> };
> @@ -254,7 +256,7 @@ int configure_and_run_sha_dma(struct acp_dev_data *adata, void *image_addr,
> }
> }
>
> - if (adata->signed_fw_image)
> + if (adata->quirks && adata->quirks->signed_fw_image)
> snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_INCLUDE_HDR, ACP_SHA_HEADER);
>
> snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_STRT_ADDR, start_addr);
> @@ -738,26 +740,27 @@ int amd_sof_acp_probe(struct snd_sof_dev *sdev)
> sdev->debug_box.offset = sdev->host_box.offset + sdev->host_box.size;
> sdev->debug_box.size = BOX_SIZE_1024;
>
> - adata->signed_fw_image = false;
> dmi_id = dmi_first_match(acp_sof_quirk_table);
> - if (dmi_id && dmi_id->driver_data) {
> - adata->fw_code_bin = devm_kasprintf(sdev->dev, GFP_KERNEL,
> - "sof-%s-code.bin",
> - chip->name);
> - if (!adata->fw_code_bin) {
> - ret = -ENOMEM;
> - goto free_ipc_irq;
> + if (dmi_id) {
> + adata->quirks = dmi_id->driver_data;
> +
> + if (adata->quirks->signed_fw_image) {
> + adata->fw_code_bin = devm_kasprintf(sdev->dev, GFP_KERNEL,
> + "sof-%s-code.bin",
> + chip->name);
> + if (!adata->fw_code_bin) {
> + ret = -ENOMEM;
> + goto free_ipc_irq;
> + }
> +
> + adata->fw_data_bin = devm_kasprintf(sdev->dev, GFP_KERNEL,
> + "sof-%s-data.bin",
> + chip->name);
> + if (!adata->fw_data_bin) {
> + ret = -ENOMEM;
> + goto free_ipc_irq;
> + }
> }
> -
> - adata->fw_data_bin = devm_kasprintf(sdev->dev, GFP_KERNEL,
> - "sof-%s-data.bin",
> - chip->name);
> - if (!adata->fw_data_bin) {
> - ret = -ENOMEM;
> - goto free_ipc_irq;
> - }
> -
> - adata->signed_fw_image = dmi_id->driver_data;
> }
>
> adata->enable_fw_debug = enable_fw_debug;
> diff --git a/sound/soc/sof/amd/acp.h b/sound/soc/sof/amd/acp.h
> index 947068da39b5..b648ed194b9f 100644
> --- a/sound/soc/sof/amd/acp.h
> +++ b/sound/soc/sof/amd/acp.h
> @@ -207,6 +207,10 @@ struct sof_amd_acp_desc {
> u64 sdw_acpi_dev_addr;
> };
>
> +struct acp_quirk_entry {
> + bool signed_fw_image;
> +};
> +
> /* Common device data struct for ACP devices */
> struct acp_dev_data {
> struct snd_sof_dev *dev;
> @@ -236,7 +240,7 @@ struct acp_dev_data {
> u8 *data_buf;
> dma_addr_t sram_dma_addr;
> u8 *sram_data_buf;
> - bool signed_fw_image;
> + struct acp_quirk_entry *quirks;
> struct dma_descriptor dscr_info[ACP_MAX_DESC];
> struct acp_dsp_stream stream_buf[ACP_MAX_STREAM];
> struct acp_dsp_stream *dtrace_stream;
> diff --git a/sound/soc/sof/amd/vangogh.c b/sound/soc/sof/amd/vangogh.c
> index de15d21aa6d9..bc6ffdb5471a 100644
> --- a/sound/soc/sof/amd/vangogh.c
> +++ b/sound/soc/sof/amd/vangogh.c
> @@ -143,6 +143,7 @@ EXPORT_SYMBOL_NS(sof_vangogh_ops, SND_SOC_SOF_AMD_COMMON);
> int sof_vangogh_ops_init(struct snd_sof_dev *sdev)
> {
> const struct dmi_system_id *dmi_id;
> + struct acp_quirk_entry *quirks;
>
> /* common defaults */
> memcpy(&sof_vangogh_ops, &sof_acp_common_ops, sizeof(struct snd_sof_dsp_ops));
> @@ -151,8 +152,12 @@ int sof_vangogh_ops_init(struct snd_sof_dev *sdev)
> sof_vangogh_ops.num_drv = ARRAY_SIZE(vangogh_sof_dai);
>
> dmi_id = dmi_first_match(acp_sof_quirk_table);
> - if (dmi_id && dmi_id->driver_data)
> - sof_vangogh_ops.load_firmware = acp_sof_load_signed_firmware;
> + if (dmi_id) {
> + quirks = dmi_id->driver_data;
> +
> + if (quirks->signed_fw_image)
> + sof_vangogh_ops.load_firmware = acp_sof_load_signed_firmware;
> + }
>
> return 0;
> }
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v3 1/2] ASoC: SOF: amd: Move signed_fw_image to struct acp_quirk_entry
2024-02-21 6:14 ` Venkata Prasad Potturu
@ 2024-02-21 8:55 ` Cristian Ciocaltea
0 siblings, 0 replies; 13+ messages in thread
From: Cristian Ciocaltea @ 2024-02-21 8:55 UTC (permalink / raw)
To: Venkata Prasad Potturu, Pierre-Louis Bossart, Liam Girdwood,
Peter Ujfalusi, Bard Liao, Ranjani Sridharan, Daniel Baluta,
Kai Vehmanen, Mark Brown, Jaroslav Kysela, Takashi Iwai
Cc: sound-open-firmware, linux-sound, linux-kernel, kernel
On 2/21/24 08:14, Venkata Prasad Potturu wrote:
>
> On 2/21/24 01:46, Cristian Ciocaltea wrote:
>> The signed_fw_image member of struct sof_amd_acp_desc is used to enable
>> signed firmware support in the driver via the acp_sof_quirk_table.
>>
>> In preparation to support additional use cases of the quirk table (i.e.
>> adding new flags), move signed_fw_image to a new struct acp_quirk_entry
>> and update all references to it accordingly.
>>
>> No functional changes intended.
>
> If there are no new flags currently being used in this patch, and also
> no functional changes added, in this case this patch is really required?
I would say yes, as it improves the ACP SOF quirk handling by making the
implementation more readable, less error prone and open for extension,
as already mentioned.
Additionally, it should facilitate the review process, since it's
unaffected by any potential changes that might be required for the
subsequent patch.
> Also please use scripts/get_maintainer.pl in CC while sending patches,
> then only
> maintainers get notified your changes.
I've already done that. Did I miss something?
Regards,
Cristian
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3 1/2] ASoC: SOF: amd: Move signed_fw_image to struct acp_quirk_entry
2024-02-20 20:16 ` [PATCH v3 1/2] ASoC: SOF: amd: Move signed_fw_image to struct acp_quirk_entry Cristian Ciocaltea
2024-02-21 6:14 ` Venkata Prasad Potturu
@ 2024-02-21 7:28 ` Venkata Prasad Potturu
2024-02-21 9:35 ` AngeloGioacchino Del Regno
2 siblings, 0 replies; 13+ messages in thread
From: Venkata Prasad Potturu @ 2024-02-21 7:28 UTC (permalink / raw)
To: Cristian Ciocaltea, Pierre-Louis Bossart, Liam Girdwood,
Peter Ujfalusi, Bard Liao, Ranjani Sridharan, Daniel Baluta,
Kai Vehmanen, Mark Brown, Jaroslav Kysela, Takashi Iwai
Cc: sound-open-firmware, linux-sound, linux-kernel, kernel
On 2/21/24 01:46, Cristian Ciocaltea wrote:
> The signed_fw_image member of struct sof_amd_acp_desc is used to enable
> signed firmware support in the driver via the acp_sof_quirk_table.
>
> In preparation to support additional use cases of the quirk table (i.e.
> adding new flags), move signed_fw_image to a new struct acp_quirk_entry
> and update all references to it accordingly.
>
> No functional changes intended.
If there are no new flags currently being used in this patch, and also
no functional changes added, in this case this patch is really required?
Also please use scripts/get_maintainer.pl and add authors in CC while
sending patches, then only
maintainers and code authors gets notified your changes.
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
> sound/soc/sof/amd/acp-loader.c | 2 +-
> sound/soc/sof/amd/acp.c | 47 ++++++++++++++++++----------------
> sound/soc/sof/amd/acp.h | 6 ++++-
> sound/soc/sof/amd/vangogh.c | 9 +++++--
> 4 files changed, 38 insertions(+), 26 deletions(-)
>
> diff --git a/sound/soc/sof/amd/acp-loader.c b/sound/soc/sof/amd/acp-loader.c
> index d2d21478399e..aad904839b81 100644
> --- a/sound/soc/sof/amd/acp-loader.c
> +++ b/sound/soc/sof/amd/acp-loader.c
> @@ -173,7 +173,7 @@ int acp_dsp_pre_fw_run(struct snd_sof_dev *sdev)
>
> adata = sdev->pdata->hw_pdata;
>
> - if (adata->signed_fw_image)
> + if (adata->quirks && adata->quirks->signed_fw_image)
> size_fw = adata->fw_bin_size - ACP_FIRMWARE_SIGNATURE;
> else
> size_fw = adata->fw_bin_size;
> diff --git a/sound/soc/sof/amd/acp.c b/sound/soc/sof/amd/acp.c
> index 9b3c26210db3..9d9197fa83ed 100644
> --- a/sound/soc/sof/amd/acp.c
> +++ b/sound/soc/sof/amd/acp.c
> @@ -20,12 +20,14 @@
> #include "acp.h"
> #include "acp-dsp-offset.h"
>
> -#define SECURED_FIRMWARE 1
> -
> static bool enable_fw_debug;
> module_param(enable_fw_debug, bool, 0444);
> MODULE_PARM_DESC(enable_fw_debug, "Enable Firmware debug");
>
> +static struct acp_quirk_entry quirk_valve_galileo = {
> + .signed_fw_image = true,
> +};
> +
> const struct dmi_system_id acp_sof_quirk_table[] = {
> {
> /* Steam Deck OLED device */
> @@ -33,7 +35,7 @@ const struct dmi_system_id acp_sof_quirk_table[] = {
> DMI_MATCH(DMI_SYS_VENDOR, "Valve"),
> DMI_MATCH(DMI_PRODUCT_NAME, "Galileo"),
> },
> - .driver_data = (void *)SECURED_FIRMWARE,
> + .driver_data = &quirk_valve_galileo,
> },
> {}
> };
> @@ -254,7 +256,7 @@ int configure_and_run_sha_dma(struct acp_dev_data *adata, void *image_addr,
> }
> }
>
> - if (adata->signed_fw_image)
> + if (adata->quirks && adata->quirks->signed_fw_image)
> snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_INCLUDE_HDR, ACP_SHA_HEADER);
>
> snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_STRT_ADDR, start_addr);
> @@ -738,26 +740,27 @@ int amd_sof_acp_probe(struct snd_sof_dev *sdev)
> sdev->debug_box.offset = sdev->host_box.offset + sdev->host_box.size;
> sdev->debug_box.size = BOX_SIZE_1024;
>
> - adata->signed_fw_image = false;
> dmi_id = dmi_first_match(acp_sof_quirk_table);
> - if (dmi_id && dmi_id->driver_data) {
> - adata->fw_code_bin = devm_kasprintf(sdev->dev, GFP_KERNEL,
> - "sof-%s-code.bin",
> - chip->name);
> - if (!adata->fw_code_bin) {
> - ret = -ENOMEM;
> - goto free_ipc_irq;
> + if (dmi_id) {
> + adata->quirks = dmi_id->driver_data;
> +
> + if (adata->quirks->signed_fw_image) {
> + adata->fw_code_bin = devm_kasprintf(sdev->dev, GFP_KERNEL,
> + "sof-%s-code.bin",
> + chip->name);
> + if (!adata->fw_code_bin) {
> + ret = -ENOMEM;
> + goto free_ipc_irq;
> + }
> +
> + adata->fw_data_bin = devm_kasprintf(sdev->dev, GFP_KERNEL,
> + "sof-%s-data.bin",
> + chip->name);
> + if (!adata->fw_data_bin) {
> + ret = -ENOMEM;
> + goto free_ipc_irq;
> + }
> }
> -
> - adata->fw_data_bin = devm_kasprintf(sdev->dev, GFP_KERNEL,
> - "sof-%s-data.bin",
> - chip->name);
> - if (!adata->fw_data_bin) {
> - ret = -ENOMEM;
> - goto free_ipc_irq;
> - }
> -
> - adata->signed_fw_image = dmi_id->driver_data;
> }
>
> adata->enable_fw_debug = enable_fw_debug;
> diff --git a/sound/soc/sof/amd/acp.h b/sound/soc/sof/amd/acp.h
> index 947068da39b5..b648ed194b9f 100644
> --- a/sound/soc/sof/amd/acp.h
> +++ b/sound/soc/sof/amd/acp.h
> @@ -207,6 +207,10 @@ struct sof_amd_acp_desc {
> u64 sdw_acpi_dev_addr;
> };
>
> +struct acp_quirk_entry {
> + bool signed_fw_image;
> +};
> +
> /* Common device data struct for ACP devices */
> struct acp_dev_data {
> struct snd_sof_dev *dev;
> @@ -236,7 +240,7 @@ struct acp_dev_data {
> u8 *data_buf;
> dma_addr_t sram_dma_addr;
> u8 *sram_data_buf;
> - bool signed_fw_image;
> + struct acp_quirk_entry *quirks;
> struct dma_descriptor dscr_info[ACP_MAX_DESC];
> struct acp_dsp_stream stream_buf[ACP_MAX_STREAM];
> struct acp_dsp_stream *dtrace_stream;
> diff --git a/sound/soc/sof/amd/vangogh.c b/sound/soc/sof/amd/vangogh.c
> index de15d21aa6d9..bc6ffdb5471a 100644
> --- a/sound/soc/sof/amd/vangogh.c
> +++ b/sound/soc/sof/amd/vangogh.c
> @@ -143,6 +143,7 @@ EXPORT_SYMBOL_NS(sof_vangogh_ops, SND_SOC_SOF_AMD_COMMON);
> int sof_vangogh_ops_init(struct snd_sof_dev *sdev)
> {
> const struct dmi_system_id *dmi_id;
> + struct acp_quirk_entry *quirks;
>
> /* common defaults */
> memcpy(&sof_vangogh_ops, &sof_acp_common_ops, sizeof(struct snd_sof_dsp_ops));
> @@ -151,8 +152,12 @@ int sof_vangogh_ops_init(struct snd_sof_dev *sdev)
> sof_vangogh_ops.num_drv = ARRAY_SIZE(vangogh_sof_dai);
>
> dmi_id = dmi_first_match(acp_sof_quirk_table);
> - if (dmi_id && dmi_id->driver_data)
> - sof_vangogh_ops.load_firmware = acp_sof_load_signed_firmware;
> + if (dmi_id) {
> + quirks = dmi_id->driver_data;
> +
> + if (quirks->signed_fw_image)
> + sof_vangogh_ops.load_firmware = acp_sof_load_signed_firmware;
> + }
>
> return 0;
> }
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v3 1/2] ASoC: SOF: amd: Move signed_fw_image to struct acp_quirk_entry
2024-02-20 20:16 ` [PATCH v3 1/2] ASoC: SOF: amd: Move signed_fw_image to struct acp_quirk_entry Cristian Ciocaltea
2024-02-21 6:14 ` Venkata Prasad Potturu
2024-02-21 7:28 ` Venkata Prasad Potturu
@ 2024-02-21 9:35 ` AngeloGioacchino Del Regno
2024-02-21 10:29 ` Cristian Ciocaltea
2 siblings, 1 reply; 13+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-02-21 9:35 UTC (permalink / raw)
To: Cristian Ciocaltea, Pierre-Louis Bossart, Liam Girdwood,
Peter Ujfalusi, Bard Liao, Ranjani Sridharan, Daniel Baluta,
Kai Vehmanen, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Venkata Prasad Potturu
Cc: sound-open-firmware, linux-sound, linux-kernel, kernel
Il 20/02/24 21:16, Cristian Ciocaltea ha scritto:
> The signed_fw_image member of struct sof_amd_acp_desc is used to enable
> signed firmware support in the driver via the acp_sof_quirk_table.
>
> In preparation to support additional use cases of the quirk table (i.e.
> adding new flags), move signed_fw_image to a new struct acp_quirk_entry
> and update all references to it accordingly.
>
> No functional changes intended.
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
> sound/soc/sof/amd/acp-loader.c | 2 +-
> sound/soc/sof/amd/acp.c | 47 ++++++++++++++++++----------------
> sound/soc/sof/amd/acp.h | 6 ++++-
> sound/soc/sof/amd/vangogh.c | 9 +++++--
> 4 files changed, 38 insertions(+), 26 deletions(-)
>
> diff --git a/sound/soc/sof/amd/acp-loader.c b/sound/soc/sof/amd/acp-loader.c
> index d2d21478399e..aad904839b81 100644
> --- a/sound/soc/sof/amd/acp-loader.c
> +++ b/sound/soc/sof/amd/acp-loader.c
> @@ -173,7 +173,7 @@ int acp_dsp_pre_fw_run(struct snd_sof_dev *sdev)
>
> adata = sdev->pdata->hw_pdata;
>
> - if (adata->signed_fw_image)
> + if (adata->quirks && adata->quirks->signed_fw_image)
> size_fw = adata->fw_bin_size - ACP_FIRMWARE_SIGNATURE;
> else
> size_fw = adata->fw_bin_size;
> diff --git a/sound/soc/sof/amd/acp.c b/sound/soc/sof/amd/acp.c
> index 9b3c26210db3..9d9197fa83ed 100644
> --- a/sound/soc/sof/amd/acp.c
> +++ b/sound/soc/sof/amd/acp.c
> @@ -20,12 +20,14 @@
> #include "acp.h"
> #include "acp-dsp-offset.h"
>
> -#define SECURED_FIRMWARE 1
> -
> static bool enable_fw_debug;
> module_param(enable_fw_debug, bool, 0444);
> MODULE_PARM_DESC(enable_fw_debug, "Enable Firmware debug");
>
> +static struct acp_quirk_entry quirk_valve_galileo = {
> + .signed_fw_image = true,
Hello Cristian,
are you sure that a structure holding "quirks" is the right choice here?
That probably comes as a personal preference, but I would simply pass a `u32 flags`
and structure the quirks as bits.
#define ACP_SIGNED_FW_IMAGE BIT(0)
#define ACP_SOMETHING_ELSE BIT(1)
flags = BIT(SIGNED_FW_IMAGE) | BIT(SOMETHING_ELSE);
if (flags & BIT(SIGNED_FW_IMAGE))
do_something()
What do you think?
Cheers,
Angelo
> +};
> +
> const struct dmi_system_id acp_sof_quirk_table[] = {
> {
> /* Steam Deck OLED device */
> @@ -33,7 +35,7 @@ const struct dmi_system_id acp_sof_quirk_table[] = {
> DMI_MATCH(DMI_SYS_VENDOR, "Valve"),
> DMI_MATCH(DMI_PRODUCT_NAME, "Galileo"),
> },
> - .driver_data = (void *)SECURED_FIRMWARE,
> + .driver_data = &quirk_valve_galileo,
> },
> {}
> };
> @@ -254,7 +256,7 @@ int configure_and_run_sha_dma(struct acp_dev_data *adata, void *image_addr,
> }
> }
>
> - if (adata->signed_fw_image)
> + if (adata->quirks && adata->quirks->signed_fw_image)
> snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_INCLUDE_HDR, ACP_SHA_HEADER);
>
> snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_STRT_ADDR, start_addr);
> @@ -738,26 +740,27 @@ int amd_sof_acp_probe(struct snd_sof_dev *sdev)
> sdev->debug_box.offset = sdev->host_box.offset + sdev->host_box.size;
> sdev->debug_box.size = BOX_SIZE_1024;
>
> - adata->signed_fw_image = false;
> dmi_id = dmi_first_match(acp_sof_quirk_table);
> - if (dmi_id && dmi_id->driver_data) {
> - adata->fw_code_bin = devm_kasprintf(sdev->dev, GFP_KERNEL,
> - "sof-%s-code.bin",
> - chip->name);
> - if (!adata->fw_code_bin) {
> - ret = -ENOMEM;
> - goto free_ipc_irq;
> + if (dmi_id) {
> + adata->quirks = dmi_id->driver_data;
> +
> + if (adata->quirks->signed_fw_image) {
> + adata->fw_code_bin = devm_kasprintf(sdev->dev, GFP_KERNEL,
> + "sof-%s-code.bin",
> + chip->name);
> + if (!adata->fw_code_bin) {
> + ret = -ENOMEM;
> + goto free_ipc_irq;
> + }
> +
> + adata->fw_data_bin = devm_kasprintf(sdev->dev, GFP_KERNEL,
> + "sof-%s-data.bin",
> + chip->name);
> + if (!adata->fw_data_bin) {
> + ret = -ENOMEM;
> + goto free_ipc_irq;
> + }
> }
> -
> - adata->fw_data_bin = devm_kasprintf(sdev->dev, GFP_KERNEL,
> - "sof-%s-data.bin",
> - chip->name);
> - if (!adata->fw_data_bin) {
> - ret = -ENOMEM;
> - goto free_ipc_irq;
> - }
> -
> - adata->signed_fw_image = dmi_id->driver_data;
> }
>
> adata->enable_fw_debug = enable_fw_debug;
> diff --git a/sound/soc/sof/amd/acp.h b/sound/soc/sof/amd/acp.h
> index 947068da39b5..b648ed194b9f 100644
> --- a/sound/soc/sof/amd/acp.h
> +++ b/sound/soc/sof/amd/acp.h
> @@ -207,6 +207,10 @@ struct sof_amd_acp_desc {
> u64 sdw_acpi_dev_addr;
> };
>
> +struct acp_quirk_entry {
> + bool signed_fw_image;
> +};
> +
> /* Common device data struct for ACP devices */
> struct acp_dev_data {
> struct snd_sof_dev *dev;
> @@ -236,7 +240,7 @@ struct acp_dev_data {
> u8 *data_buf;
> dma_addr_t sram_dma_addr;
> u8 *sram_data_buf;
> - bool signed_fw_image;
> + struct acp_quirk_entry *quirks;
> struct dma_descriptor dscr_info[ACP_MAX_DESC];
> struct acp_dsp_stream stream_buf[ACP_MAX_STREAM];
> struct acp_dsp_stream *dtrace_stream;
> diff --git a/sound/soc/sof/amd/vangogh.c b/sound/soc/sof/amd/vangogh.c
> index de15d21aa6d9..bc6ffdb5471a 100644
> --- a/sound/soc/sof/amd/vangogh.c
> +++ b/sound/soc/sof/amd/vangogh.c
> @@ -143,6 +143,7 @@ EXPORT_SYMBOL_NS(sof_vangogh_ops, SND_SOC_SOF_AMD_COMMON);
> int sof_vangogh_ops_init(struct snd_sof_dev *sdev)
> {
> const struct dmi_system_id *dmi_id;
> + struct acp_quirk_entry *quirks;
>
> /* common defaults */
> memcpy(&sof_vangogh_ops, &sof_acp_common_ops, sizeof(struct snd_sof_dsp_ops));
> @@ -151,8 +152,12 @@ int sof_vangogh_ops_init(struct snd_sof_dev *sdev)
> sof_vangogh_ops.num_drv = ARRAY_SIZE(vangogh_sof_dai);
>
> dmi_id = dmi_first_match(acp_sof_quirk_table);
> - if (dmi_id && dmi_id->driver_data)
> - sof_vangogh_ops.load_firmware = acp_sof_load_signed_firmware;
> + if (dmi_id) {
> + quirks = dmi_id->driver_data;
> +
> + if (quirks->signed_fw_image)
> + sof_vangogh_ops.load_firmware = acp_sof_load_signed_firmware;
> + }
>
> return 0;
> }
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v3 1/2] ASoC: SOF: amd: Move signed_fw_image to struct acp_quirk_entry
2024-02-21 9:35 ` AngeloGioacchino Del Regno
@ 2024-02-21 10:29 ` Cristian Ciocaltea
2024-02-21 10:35 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 13+ messages in thread
From: Cristian Ciocaltea @ 2024-02-21 10:29 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, Pierre-Louis Bossart, Liam Girdwood,
Peter Ujfalusi, Bard Liao, Ranjani Sridharan, Daniel Baluta,
Kai Vehmanen, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Venkata Prasad Potturu
Cc: sound-open-firmware, linux-sound, linux-kernel, kernel
On 2/21/24 11:35, AngeloGioacchino Del Regno wrote:
> Il 20/02/24 21:16, Cristian Ciocaltea ha scritto:
>> The signed_fw_image member of struct sof_amd_acp_desc is used to enable
>> signed firmware support in the driver via the acp_sof_quirk_table.
>>
>> In preparation to support additional use cases of the quirk table (i.e.
>> adding new flags), move signed_fw_image to a new struct acp_quirk_entry
>> and update all references to it accordingly.
>>
>> No functional changes intended.
>>
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>> ---
>> sound/soc/sof/amd/acp-loader.c | 2 +-
>> sound/soc/sof/amd/acp.c | 47 ++++++++++++++++++----------------
>> sound/soc/sof/amd/acp.h | 6 ++++-
>> sound/soc/sof/amd/vangogh.c | 9 +++++--
>> 4 files changed, 38 insertions(+), 26 deletions(-)
>>
>> diff --git a/sound/soc/sof/amd/acp-loader.c
>> b/sound/soc/sof/amd/acp-loader.c
>> index d2d21478399e..aad904839b81 100644
>> --- a/sound/soc/sof/amd/acp-loader.c
>> +++ b/sound/soc/sof/amd/acp-loader.c
>> @@ -173,7 +173,7 @@ int acp_dsp_pre_fw_run(struct snd_sof_dev *sdev)
>> adata = sdev->pdata->hw_pdata;
>> - if (adata->signed_fw_image)
>> + if (adata->quirks && adata->quirks->signed_fw_image)
>> size_fw = adata->fw_bin_size - ACP_FIRMWARE_SIGNATURE;
>> else
>> size_fw = adata->fw_bin_size;
>> diff --git a/sound/soc/sof/amd/acp.c b/sound/soc/sof/amd/acp.c
>> index 9b3c26210db3..9d9197fa83ed 100644
>> --- a/sound/soc/sof/amd/acp.c
>> +++ b/sound/soc/sof/amd/acp.c
>> @@ -20,12 +20,14 @@
>> #include "acp.h"
>> #include "acp-dsp-offset.h"
>> -#define SECURED_FIRMWARE 1
>> -
>> static bool enable_fw_debug;
>> module_param(enable_fw_debug, bool, 0444);
>> MODULE_PARM_DESC(enable_fw_debug, "Enable Firmware debug");
>> +static struct acp_quirk_entry quirk_valve_galileo = {
>> + .signed_fw_image = true,
>
> Hello Cristian,
>
> are you sure that a structure holding "quirks" is the right choice here?
>
> That probably comes as a personal preference, but I would simply pass a
> `u32 flags`
> and structure the quirks as bits.
>
> #define ACP_SIGNED_FW_IMAGE BIT(0)
> #define ACP_SOMETHING_ELSE BIT(1)
>
> flags = BIT(SIGNED_FW_IMAGE) | BIT(SOMETHING_ELSE);
>
> if (flags & BIT(SIGNED_FW_IMAGE))
> do_something()
>
> What do you think?
Hi Angelo,
The flags approach was actually my first thought and I think that would
have been the best choice if the quirks usage was limited to a single
file (acp.c).
Since they need to be exposed externally as well (acp-loader.c,
vangogh.c) and already using a dedicated member in struct
sof_amd_acp_desc related to the existing quirk, I found the "quirks"
struct solution a bit more natural/convenient to follow (I've done a bit
of research before and noticed other drivers having similar handling).
However, as you already pointed out, it may also come down to individual
preferences, so I'm open to using the flags if there is not enough
reasoning to stick with the current implementation.
Thanks,
Cristian
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v3 1/2] ASoC: SOF: amd: Move signed_fw_image to struct acp_quirk_entry
2024-02-21 10:29 ` Cristian Ciocaltea
@ 2024-02-21 10:35 ` AngeloGioacchino Del Regno
2024-02-21 10:59 ` Cristian Ciocaltea
0 siblings, 1 reply; 13+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-02-21 10:35 UTC (permalink / raw)
To: Cristian Ciocaltea, Pierre-Louis Bossart, Liam Girdwood,
Peter Ujfalusi, Bard Liao, Ranjani Sridharan, Daniel Baluta,
Kai Vehmanen, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Venkata Prasad Potturu
Cc: sound-open-firmware, linux-sound, linux-kernel, kernel
Il 21/02/24 11:29, Cristian Ciocaltea ha scritto:
> On 2/21/24 11:35, AngeloGioacchino Del Regno wrote:
>> Il 20/02/24 21:16, Cristian Ciocaltea ha scritto:
>>> The signed_fw_image member of struct sof_amd_acp_desc is used to enable
>>> signed firmware support in the driver via the acp_sof_quirk_table.
>>>
>>> In preparation to support additional use cases of the quirk table (i.e.
>>> adding new flags), move signed_fw_image to a new struct acp_quirk_entry
>>> and update all references to it accordingly.
>>>
>>> No functional changes intended.
>>>
>>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>>> ---
>>> sound/soc/sof/amd/acp-loader.c | 2 +-
>>> sound/soc/sof/amd/acp.c | 47 ++++++++++++++++++----------------
>>> sound/soc/sof/amd/acp.h | 6 ++++-
>>> sound/soc/sof/amd/vangogh.c | 9 +++++--
>>> 4 files changed, 38 insertions(+), 26 deletions(-)
>>>
>>> diff --git a/sound/soc/sof/amd/acp-loader.c
>>> b/sound/soc/sof/amd/acp-loader.c
>>> index d2d21478399e..aad904839b81 100644
>>> --- a/sound/soc/sof/amd/acp-loader.c
>>> +++ b/sound/soc/sof/amd/acp-loader.c
>>> @@ -173,7 +173,7 @@ int acp_dsp_pre_fw_run(struct snd_sof_dev *sdev)
>>> adata = sdev->pdata->hw_pdata;
>>> - if (adata->signed_fw_image)
>>> + if (adata->quirks && adata->quirks->signed_fw_image)
>>> size_fw = adata->fw_bin_size - ACP_FIRMWARE_SIGNATURE;
>>> else
>>> size_fw = adata->fw_bin_size;
>>> diff --git a/sound/soc/sof/amd/acp.c b/sound/soc/sof/amd/acp.c
>>> index 9b3c26210db3..9d9197fa83ed 100644
>>> --- a/sound/soc/sof/amd/acp.c
>>> +++ b/sound/soc/sof/amd/acp.c
>>> @@ -20,12 +20,14 @@
>>> #include "acp.h"
>>> #include "acp-dsp-offset.h"
>>> -#define SECURED_FIRMWARE 1
>>> -
>>> static bool enable_fw_debug;
>>> module_param(enable_fw_debug, bool, 0444);
>>> MODULE_PARM_DESC(enable_fw_debug, "Enable Firmware debug");
>>> +static struct acp_quirk_entry quirk_valve_galileo = {
>>> + .signed_fw_image = true,
>>
>> Hello Cristian,
>>
>> are you sure that a structure holding "quirks" is the right choice here?
>>
>> That probably comes as a personal preference, but I would simply pass a
>> `u32 flags`
>> and structure the quirks as bits.
>>
>> #define ACP_SIGNED_FW_IMAGE BIT(0)
>> #define ACP_SOMETHING_ELSE BIT(1)
>>
>> flags = BIT(SIGNED_FW_IMAGE) | BIT(SOMETHING_ELSE);
That should've been
flags = SIGNED_FW_IMAGE | SOMETHING_ELSE;
>>
>> if (flags & BIT(SIGNED_FW_IMAGE))
and this
if (flags & SIGNED_FW_IMAGE)
... I have no idea why I added a nested BIT(BIT()) in there, something in
my brain started ticking sideways, lol.
>> do_something()
>>
>> What do you think?
>
> Hi Angelo,
>
> The flags approach was actually my first thought and I think that would
> have been the best choice if the quirks usage was limited to a single
> file (acp.c).
>
> Since they need to be exposed externally as well (acp-loader.c,
> vangogh.c) and already using a dedicated member in struct
> sof_amd_acp_desc related to the existing quirk, I found the "quirks"
> struct solution a bit more natural/convenient to follow (I've done a bit
> of research before and noticed other drivers having similar handling).
>
> However, as you already pointed out, it may also come down to individual
> preferences, so I'm open to using the flags if there is not enough
> reasoning to stick with the current implementation.
Of course the definitions should be put in a "common header" for that to
actually work in your described situation, but it's not a big deal.
Mine wasn't a strong opinion: that does actually matter in case you expect
more quirks (or something that is not a quirk, but a functional flag instead)
to eventually get there... but otherwise, it's actually the same.
It's your choice in the end, I'm fine with both anyway :-)
Cheers,
Angelo
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v3 1/2] ASoC: SOF: amd: Move signed_fw_image to struct acp_quirk_entry
2024-02-21 10:35 ` AngeloGioacchino Del Regno
@ 2024-02-21 10:59 ` Cristian Ciocaltea
0 siblings, 0 replies; 13+ messages in thread
From: Cristian Ciocaltea @ 2024-02-21 10:59 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, Pierre-Louis Bossart, Liam Girdwood,
Peter Ujfalusi, Bard Liao, Ranjani Sridharan, Daniel Baluta,
Kai Vehmanen, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Venkata Prasad Potturu
Cc: sound-open-firmware, linux-sound, linux-kernel, kernel
On 2/21/24 12:35, AngeloGioacchino Del Regno wrote:
> Il 21/02/24 11:29, Cristian Ciocaltea ha scritto:
>> On 2/21/24 11:35, AngeloGioacchino Del Regno wrote:
>>> Il 20/02/24 21:16, Cristian Ciocaltea ha scritto:
>>>> The signed_fw_image member of struct sof_amd_acp_desc is used to enable
>>>> signed firmware support in the driver via the acp_sof_quirk_table.
>>>>
>>>> In preparation to support additional use cases of the quirk table (i.e.
>>>> adding new flags), move signed_fw_image to a new struct acp_quirk_entry
>>>> and update all references to it accordingly.
>>>>
[...]
>>> are you sure that a structure holding "quirks" is the right choice here?
>>>
>>> That probably comes as a personal preference, but I would simply pass a
>>> `u32 flags`
>>> and structure the quirks as bits.
>>>
>>> #define ACP_SIGNED_FW_IMAGE BIT(0)
>>> #define ACP_SOMETHING_ELSE BIT(1)
>>>
>>> flags = BIT(SIGNED_FW_IMAGE) | BIT(SOMETHING_ELSE);
>
> That should've been
> flags = SIGNED_FW_IMAGE | SOMETHING_ELSE;
>
>>>
>>> if (flags & BIT(SIGNED_FW_IMAGE))
>
> and this
> if (flags & SIGNED_FW_IMAGE)
>
> ... I have no idea why I added a nested BIT(BIT()) in there, something in
> my brain started ticking sideways, lol.
Yeah, don't worry about that, it's perfectly clear what you initially
meant.. :-)
>>> do_something()
>>>
>>> What do you think?
>>
>> Hi Angelo,
>>
>> The flags approach was actually my first thought and I think that would
>> have been the best choice if the quirks usage was limited to a single
>> file (acp.c).
>>
>> Since they need to be exposed externally as well (acp-loader.c,
>> vangogh.c) and already using a dedicated member in struct
>> sof_amd_acp_desc related to the existing quirk, I found the "quirks"
>> struct solution a bit more natural/convenient to follow (I've done a bit
>> of research before and noticed other drivers having similar handling).
>>
>> However, as you already pointed out, it may also come down to individual
>> preferences, so I'm open to using the flags if there is not enough
>> reasoning to stick with the current implementation.
>
> Of course the definitions should be put in a "common header" for that to
> actually work in your described situation, but it's not a big deal.
>
> Mine wasn't a strong opinion: that does actually matter in case you expect
> more quirks (or something that is not a quirk, but a functional flag
> instead)
> to eventually get there... but otherwise, it's actually the same.
>
> It's your choice in the end, I'm fine with both anyway :-)
Great, thanks! :-)
^ permalink raw reply [flat|nested] 13+ messages in thread