Re: [PATCH] Linux Laptop ACP6x microphone "quirk list" addition

Re: [PATCH] Linux Laptop ACP6x microphone "quirk list" addition

[Mario Limonciello]

On 1/5/2025 17:14, louison fourmoy wrote:
> Hi,
> 
> The following patch aims to enable the use of the built in microphone 
> for the Lenovo Ideapad Slim 5 Gen 10 (AMD). Currently the inbuilt 
> microphone of the laptop is not usable with a “stock” kernel and kernel 
> manipulation is necessary to use it. This patch adds the correct model 
> in the list of models under sound/soc/amd/yc/acp6x-mach.c

In a patch there is no need to say "this patch" or the "following patch".

When a patch is accepted it becomes a commit, and the commit message 
won't read right.

I'd suggest taking a gander at 
https://www.kernel.org/doc/html/v6.13-rc4/process/submitting-patches.html.

> 
> Signed-off-by: Louison Fourmoy <louison.fourmoy@orange.fr>
> 
> Patch :

Specifically over here you don't need to use "Patch: ".

You also need to correct the subject, and don't write the patch like an 
email.

Here is another one of these that you can reference for submitting a 
better patch.

https://github.com/torvalds/linux/commit/b682aa788e5f9f1ddacdfbb453e49fd3f4e83721
> 
> --- linux/sound/soc/amd/yc/acp6x-mach.c.orig 2025-01-05 
> 23:37:36.927778168 +0100
> +++ linux/sound/soc/amd/yc/acp6x-mach.c 2025-01-05 23:38:28.066418534 +0100
> @@ -304,6 +304,13 @@ static const struct dmi_system_id yc_acp
> 
>               DMI_MATCH(DMI_PRODUCT_NAME, “83AS”),
>           }
>       },
> +         {
> +             .driver_data = &acp6x_card,
> +             .matches = {
> +                     DMI_MATCH(DMI_BOARD_VENDOR, “LENOVO”),
> +                     DMI_MATCH(DMI_PRODUCT_NAME, “83J3”),
> +             }
> +         },
>       {
> .driver_data = &acp6x_card,
> .matches = {
> 

[PATCH] Linux Laptop ACP6x microphone "quirk list" addition

[Louison Fourmoy]

Hi,

The following patch aims to enable the use of the built in microphone 
for the Lenovo Ideapad Slim 5 Gen 10 (AMD). Currently the inbuilt 
microphone of the laptop is not usable with a “stock” kernel and kernel 
manipulation is necessary to use it. This patch adds the correct model 
in the list of models under sound/soc/amd/yc/acp6x-mach.c

Signed-off-by: Louison Fourmoy <louison.fourmoy@orange.fr 
<mailto:louison.fourmoy@orange.fr>>

Patch :

--- linux/sound/soc/amd/yc/acp6x-mach.c.orig 2025-01-05 
23:37:36.927778168 +0100
+++ linux/sound/soc/amd/yc/acp6x-mach.c 2025-01-05 23:38:28.066418534 +0100
@@ -304,6 +304,13 @@ static const struct dmi_system_id yc_acp

              DMI_MATCH(DMI_PRODUCT_NAME, “83AS”),
          }
      },
+         {
+             .driver_data = &acp6x_card,
+             .matches = {
+                     DMI_MATCH(DMI_BOARD_VENDOR, “LENOVO”),
+                     DMI_MATCH(DMI_PRODUCT_NAME, “83J3”),
+             }
+         },
      {
.driver_data = &acp6x_card,
.matches = {