Re: [PATCH 07/13] ASoC: Intel: avs: Add MODULE_FIRMWARE to inform about FW

[Cezary Rojewski <cezary.rojewski@intel.com>]

On 2025-01-17 4:59 PM, Pierre-Louis Bossart wrote:
> 
>>>> +MODULE_FIRMWARE("intel/tgl/dsp_basefw.bin");
>>>> +MODULE_FIRMWARE("intel/ehl/dsp_basefw.bin");
>>>> +MODULE_FIRMWARE("intel/adl/dsp_basefw.bin");
>>>> +MODULE_FIRMWARE("intel/adl_n/dsp_basefw.bin");
>>>
>>> If you start listing the variants of ADL, then shouldn't you also list the variants of TGL?
>>> Same for CNL, there are multiple variants, not to mention different signing keys.
>>
>> The only reason ADL and ADL-N are listed separately is binary incompatibility - MEU differs between the two. In essence, one can use ADL-binaries for all ADL/RPL based platforms _except_ for ADL-N based ones. The code is the same, the verification process is different. For all other major platforms, no MEU differences so one binary covers all variants.
>>
>> In regard to the key, the approach is: it's ignored.
>>
>> Whatever is in the directory under 'dsp_basefw.bin' will be attempted for booting the DSP. By default, what lands on the market is a production-type-signed binaries. Internally CI runs with prod -or- debug signed binaries but we do not intend to share the latter to the official linux-firmware repo.
> 
> You didn't get my point. There are also binary incompatibilities between TGL and TGL-H (different number of cores) and in the CNL/CML space there were different production keys and MEU snaffus requiring different binaries to be released.
> This wasn't about the production/debug problem, I was only referring to 'production' releases.

I'm afraid there are differences between cAVS/ACE firmware and SOF. When 
it comes to the cAVS/ACE, TGL devices are all handled using the exact 
same binary and the firmware reads certain hardware capabilities in 
runtime. CML-R (CML platform with TGP PCH) falls into the same category.

Instead, the cAVS/ACE expects the software to send BUS_HARDWARE_ID IPC 
to inform it about details of the hardware revision e.g.: the stepping. 
Firmware may decide to tailor certain flows depending on that detailed 
information.

Kind regards,
Czarek