Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Vasiliy Kovalev <kovalev@altlinux.org>
To: Takashi Iwai <tiwai@suse.de>, Kai-Heng Feng <kaihengf@nvidia.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	bo liu <bo.liu@senarytech.com>
Subject: Re: [PATCH v2] ALSA: hda/conexant - Fix audio routing for HP EliteOne 1000 G2
Date: Wed, 16 Oct 2024 11:14:55 +0300	[thread overview]
Message-ID: <f3836285-befc-92af-38ef-e58a84f920fd@basealt.ru> (raw)
In-Reply-To: <6ef8fef9-c44d-40d6-f7e1-236e68175071@basealt.ru>


10.10.2024 11:36, Vasiliy Kovalev пишет:
> 
> 10.10.2024 08:17, Takashi Iwai wrote:
>> On Thu, 10 Oct 2024 05:32:18 +0200,
>> Kai-Heng Feng wrote:
>>>
>>>
>>> On 2024/10/9 9:50 PM, Takashi Iwai wrote:
>>>> On Wed, 09 Oct 2024 15:42:48 +0200,
>>>> Vasiliy Kovalev wrote:
>>>>>
>>>>> There is a problem with simultaneous audio output to headphones and
>>>>> speakers, and when headphones are turned off, the speakers also turn
>>>>> off and do not turn them on.
>>>>>
>>>>> However, it was found that if you boot linux immediately after 
>>>>> windows,
>>>>> there are no such problems. When comparing alsa-info, the only 
>>>>> difference
>>>>> is the different configuration of Node 0x1d:
>>>>>
>>>>> working conf. (windows): Pin-ctls: 0x80: HP
>>>>> not working     (linux): Pin-ctls: 0xc0: OUT HP
>>>>>
>>>>> This patch disable the AC_PINCTL_OUT_EN bit of Node 0x1d and fixes the
>>>>> described problem.
>>>
>>> Though this is already applied, is it possible to see if the issue
>>> also happens on S4?
>>>
>>> Linux doesn't put PCI devices like HDA to D3 during shutdown and
>>> reboot while Windows does, that might be the reason boot Linux after
>>> Windows can workaround the issue.
>>>
>>> Linux does put PCI devices to D3 for hibernate (S4), so we can use it
>>> as an experiment.
>>
>> Right, it should have been the cached version so that the setup is
>> reapplied automatically; i.e. replace snd_hda_set_pin_ctl() with
>> snd_hda_set_pin_ctl_cached().
>>
>> Vasiliy, care to test and submit an incremental fix?
> 
> Ok, I compiled the module with the proposed changes and sent it to the 
> user for testing on a machine with this codec. After testing, I will 
> write about the result.

Using the snd_hda_set_pin_ctl_cache() function instead of 
snd_hda_set_pin_ctl() leads to the same positive result, there are no 
problems with sound.  The patch has been sent [1]

[1] https://lore.kernel.org/all/20241016080713.46801-1-kovalev@altlinux.org/

>>
>> thanks,
>>
>> Takashi

--
Thanks,
Vasiliy Kovalev

      reply	other threads:[~2024-10-16  8:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09 13:42 [PATCH v2] ALSA: hda/conexant - Fix audio routing for HP EliteOne 1000 G2 Vasiliy Kovalev
2024-10-09 13:50 ` Takashi Iwai
2024-10-10  3:32   ` Kai-Heng Feng
2024-10-10  5:17     ` Takashi Iwai
2024-10-10  8:36       ` Vasiliy Kovalev
2024-10-16  8:14         ` Vasiliy Kovalev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3836285-befc-92af-38ef-e58a84f920fd@basealt.ru \
    --to=kovalev@altlinux.org \
    --cc=bo.liu@senarytech.com \
    --cc=kaihengf@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox