Re: [PATCH] ASoC: dt-bindings: Add dt bindings definition file for imx28 saif

[Krzysztof Kozlowski <krzk@kernel.org>]

On 28/08/2024 10:01, Lukasz Majewski wrote:
>>> +properties:
>>> +  compatible:
>>> +    const: fsl,imx28-saif
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  "#sound-dai-cells":
>>> +    const: 0
>>> +
>>> +  assigned-clock-parents: true
>>> +  assigned-clock-rates: true
>>> +  assigned-clocks: true  
>>
>> These three should be dropped, redundant.
> 
> Last two are present in definition of saif[01] in imx28.dtsi - so IMHO
> it shall be added.

But they are already accepted. Why they need to be mentioned twice?

> 
> Moreover, those are present in fsl,sg5000.yaml dt-schema description.
> 

There is no such file.

>>
>>> +
>>> +unevaluatedProperties: false
>>> +
>>> +examples:
>>> +  - |
>>> +    saif0: saif@80042000 {
>>> +        #sound-dai-cells = <0>;
>>> +        compatible = "fsl,imx28-saif";
>>> +        reg = <0x80042000 2000>;
>>> +        interrupts = <59>;
>>> +        clocks = <&clks 53>;
>>> +        dmas = <&dma_apbx 4>;
>>> +        dma-names = "rx-tx";
>>> +    };
>>> +  - |
>>> +    saif1: saif@80046000 {  
>>
>> Just one example, could be this one as more complete.
> 
> This is important, as saif1 has "fsl,saif-master" which allows to have
> full duplex PCM communication (by default on imx28 single saif is
> half-duplex).
> 
So keep saif1.

Best regards,
Krzysztof