[PATCH] Remove one of sound/oss/cmpci.c compile warnings

[PATCH] Remove one of sound/oss/cmpci.c compile warnings

[Petri Koistinen]

Hi!

This patch removes this compile warning:

sound/oss/cmpci.c: In function `cm_release_mixdev':
sound/oss/cmpci.c:1465: warning: unused variable `s'

GCC doesn't seem to unstand that VALIDATE_STATE macro uses s variable.
I hope this is correct way to fix this.

Petri

--- linux-2.6/sound/oss/cmpci.c.orig	2003-10-28 19:54:27.000000000 +0200
+++ linux-2.6/sound/oss/cmpci.c	2003-10-28 19:55:50.000000000 +0200
@@ -1462,7 +1462,9 @@

 static int cm_release_mixdev(struct inode *inode, struct file *file)
 {
-	struct cm_state *s = (struct cm_state *)file->private_data;
+	struct cm_state *s;
+
+	s = (struct cm_state *)file->private_data;

 	VALIDATE_STATE(s);
 	return 0;

Re: [PATCH] Remove one of sound/oss/cmpci.c compile warnings

[Rusty Russell]

In message <Pine.LNX.4.58.0310282002530.4918@dsl-hkigw4g29.dial.inet.fi> you write:
> Hi!
> 
> This patch removes this compile warning:
> 
> sound/oss/cmpci.c: In function `cm_release_mixdev':
> sound/oss/cmpci.c:1465: warning: unused variable `s'
> 
> GCC doesn't seem to unstand that VALIDATE_STATE macro uses s variable.
> I hope this is correct way to fix this.

Because it doesn't.  A better change would be:

VALIDATE_STATE((struct cm_state *)file->private_data);

Or to remove the entire function.

Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.