* Re: Cannot load snd-usb-audio on 3.12-rc2 [not found] <20130923234107.GA4876@xanatos> @ 2013-09-24 15:52 ` Daniel Mack 2013-09-26 8:10 ` [alsa-devel] " David Henningsson 2013-09-26 8:36 ` Takashi Iwai 1 sibling, 1 reply; 5+ messages in thread From: Daniel Mack @ 2013-09-24 15:52 UTC (permalink / raw) To: Sarah Sharp Cc: Jaroslav Kysela, Takashi Iwai, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-sound-u79uwXL29TY76Z2rM5mHXA, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw Hi Sarah, On 24.09.2013 01:41, Sarah Sharp wrote: > The snd-usb-audio driver no longer loads properly on 3.12-rc2 when I > plug in my USB headset. It worked fine on 3.11-rc4 (not sure about > vanilla 3.11). > > Trying to manually load the driver fails: > > sarah@xanatos:~$ sudo modprobe snd-usb-audio > FATAL: Error inserting snd_usb_audio > (/lib/modules/3.12.0-rc2/kernel/sound/usb/snd-usb-audio.ko): Invalid argument > > dmesg shows: > > [ 44.231668] snd_usb_audio: `-2' invalid for parameter `index' That's really strange. I just tested on an ARM board where I currently run 3.12-rc2 as well, and I can load the module without problems. Also, sound/usb/card.c (where the params are declared) hasn't seen an update in 3.12. I suspect your OS is passing "index=-2" from something like /etc/modprobe.d/* or cmdline settings. Could you investigate in that direction? HTH, Daniel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [alsa-devel] Cannot load snd-usb-audio on 3.12-rc2 2013-09-24 15:52 ` Cannot load snd-usb-audio on 3.12-rc2 Daniel Mack @ 2013-09-26 8:10 ` David Henningsson 0 siblings, 0 replies; 5+ messages in thread From: David Henningsson @ 2013-09-26 8:10 UTC (permalink / raw) To: Daniel Mack, Sarah Sharp; +Cc: Takashi Iwai, alsa-devel, linux-usb, linux-sound On 09/24/2013 05:52 PM, Daniel Mack wrote: > Hi Sarah, > > On 24.09.2013 01:41, Sarah Sharp wrote: >> The snd-usb-audio driver no longer loads properly on 3.12-rc2 when I >> plug in my USB headset. It worked fine on 3.11-rc4 (not sure about >> vanilla 3.11). >> >> Trying to manually load the driver fails: >> >> sarah@xanatos:~$ sudo modprobe snd-usb-audio >> FATAL: Error inserting snd_usb_audio >> (/lib/modules/3.12.0-rc2/kernel/sound/usb/snd-usb-audio.ko): Invalid argument >> >> dmesg shows: >> >> [ 44.231668] snd_usb_audio: `-2' invalid for parameter `index' > > That's really strange. I just tested on an ARM board where I currently > run 3.12-rc2 as well, and I can load the module without problems. Also, > sound/usb/card.c (where the params are declared) hasn't seen an update > in 3.12. > > I suspect your OS is passing "index=-2" from something like > /etc/modprobe.d/* or cmdline settings. Could you investigate in that > direction? Ubuntu has passed options snd-usb-audio index=-2 ...since ages. It is, AFAIK, a very valid way of trying to make "some other card" be card 0. This is because card 0 is the default in some apps which are not using PulseAudio, so it's mostly there for historical reasons. -- David Henningsson, Canonical Ltd. https://launchpad.net/~diwic ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Cannot load snd-usb-audio on 3.12-rc2 [not found] <20130923234107.GA4876@xanatos> 2013-09-24 15:52 ` Cannot load snd-usb-audio on 3.12-rc2 Daniel Mack @ 2013-09-26 8:36 ` Takashi Iwai [not found] ` <s5hfvssdlo2.wl%tiwai-l3A5Bk7waGM@public.gmane.org> 1 sibling, 1 reply; 5+ messages in thread From: Takashi Iwai @ 2013-09-26 8:36 UTC (permalink / raw) To: Sarah Sharp; +Cc: Jaroslav Kysela, linux-usb, linux-sound, alsa-devel At Mon, 23 Sep 2013 16:41:07 -0700, Sarah Sharp wrote: > > The snd-usb-audio driver no longer loads properly on 3.12-rc2 when I > plug in my USB headset. It worked fine on 3.11-rc4 (not sure about > vanilla 3.11). > > Trying to manually load the driver fails: > > sarah@xanatos:~$ sudo modprobe snd-usb-audio > FATAL: Error inserting snd_usb_audio > (/lib/modules/3.12.0-rc2/kernel/sound/usb/snd-usb-audio.ko): Invalid argument > > dmesg shows: > > [ 44.231668] snd_usb_audio: `-2' invalid for parameter `index' There is no corresponding code change in the USB audio driver side, so I guess it must be in the module parameter parser that got broken. Does the patch below fix? thanks, Takashi --- diff --git a/kernel/params.c b/kernel/params.c index 81c4e78..c00d5b5 100644 --- a/kernel/params.c +++ b/kernel/params.c @@ -254,11 +254,11 @@ int parse_args(const char *doing, STANDARD_PARAM_DEF(byte, unsigned char, "%hhu", unsigned long, kstrtoul); -STANDARD_PARAM_DEF(short, short, "%hi", long, kstrtoul); +STANDARD_PARAM_DEF(short, short, "%hi", long, kstrtol); STANDARD_PARAM_DEF(ushort, unsigned short, "%hu", unsigned long, kstrtoul); -STANDARD_PARAM_DEF(int, int, "%i", long, kstrtoul); +STANDARD_PARAM_DEF(int, int, "%i", long, kstrtol); STANDARD_PARAM_DEF(uint, unsigned int, "%u", unsigned long, kstrtoul); -STANDARD_PARAM_DEF(long, long, "%li", long, kstrtoul); +STANDARD_PARAM_DEF(long, long, "%li", long, kstrtol); STANDARD_PARAM_DEF(ulong, unsigned long, "%lu", unsigned long, kstrtoul); int param_set_charp(const char *val, const struct kernel_param *kp) ^ permalink raw reply related [flat|nested] 5+ messages in thread
[parent not found: <s5hfvssdlo2.wl%tiwai-l3A5Bk7waGM@public.gmane.org>]
* Re: Cannot load snd-usb-audio on 3.12-rc2 [not found] ` <s5hfvssdlo2.wl%tiwai-l3A5Bk7waGM@public.gmane.org> @ 2013-10-09 20:01 ` Sarah Sharp 2013-10-10 7:44 ` Takashi Iwai 0 siblings, 1 reply; 5+ messages in thread From: Sarah Sharp @ 2013-10-09 20:01 UTC (permalink / raw) To: Takashi Iwai Cc: Jaroslav Kysela, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-sound-u79uwXL29TY76Z2rM5mHXA, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw On Thu, Sep 26, 2013 at 10:36:29AM +0200, Takashi Iwai wrote: > At Mon, 23 Sep 2013 16:41:07 -0700, > Sarah Sharp wrote: > > > > The snd-usb-audio driver no longer loads properly on 3.12-rc2 when I > > plug in my USB headset. It worked fine on 3.11-rc4 (not sure about > > vanilla 3.11). > > > > Trying to manually load the driver fails: > > > > sarah@xanatos:~$ sudo modprobe snd-usb-audio > > FATAL: Error inserting snd_usb_audio > > (/lib/modules/3.12.0-rc2/kernel/sound/usb/snd-usb-audio.ko): Invalid argument > > > > dmesg shows: > > > > [ 44.231668] snd_usb_audio: `-2' invalid for parameter `index' > > There is no corresponding code change in the USB audio driver side, so > I guess it must be in the module parameter parser that got broken. > > Does the patch below fix? Hi Takashi, I didn't get around to applying the patch, but USB audio seems to be fixed in 3.12-rc4. Thanks! Sarah Sharp ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Cannot load snd-usb-audio on 3.12-rc2 2013-10-09 20:01 ` Sarah Sharp @ 2013-10-10 7:44 ` Takashi Iwai 0 siblings, 0 replies; 5+ messages in thread From: Takashi Iwai @ 2013-10-10 7:44 UTC (permalink / raw) To: Sarah Sharp; +Cc: Jaroslav Kysela, linux-usb, linux-sound, alsa-devel At Wed, 9 Oct 2013 13:01:08 -0700, Sarah Sharp wrote: > > On Thu, Sep 26, 2013 at 10:36:29AM +0200, Takashi Iwai wrote: > > At Mon, 23 Sep 2013 16:41:07 -0700, > > Sarah Sharp wrote: > > > > > > The snd-usb-audio driver no longer loads properly on 3.12-rc2 when I > > > plug in my USB headset. It worked fine on 3.11-rc4 (not sure about > > > vanilla 3.11). > > > > > > Trying to manually load the driver fails: > > > > > > sarah@xanatos:~$ sudo modprobe snd-usb-audio > > > FATAL: Error inserting snd_usb_audio > > > (/lib/modules/3.12.0-rc2/kernel/sound/usb/snd-usb-audio.ko): Invalid argument > > > > > > dmesg shows: > > > > > > [ 44.231668] snd_usb_audio: `-2' invalid for parameter `index' > > > > There is no corresponding code change in the USB audio driver side, so > > I guess it must be in the module parameter parser that got broken. > > > > Does the patch below fix? > > Hi Takashi, > > I didn't get around to applying the patch, but USB audio seems to be > fixed in 3.12-rc4. Yeah, Jean did the very same fix and it was already merged. thanks, Takashi ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-10-10 7:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20130923234107.GA4876@xanatos>
2013-09-24 15:52 ` Cannot load snd-usb-audio on 3.12-rc2 Daniel Mack
2013-09-26 8:10 ` [alsa-devel] " David Henningsson
2013-09-26 8:36 ` Takashi Iwai
[not found] ` <s5hfvssdlo2.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2013-10-09 20:01 ` Sarah Sharp
2013-10-10 7:44 ` Takashi Iwai
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox