public inbox for linux-sound@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Konstantinos Tsimpoukas <kostaslinuxxx@gmail.com>
Cc: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ice1712: Replacing hex with #defines
Date: Wed, 27 Aug 2014 06:17:46 +0000	[thread overview]
Message-ID: <s5hoav6foc5.wl-tiwai@suse.de> (raw)
In-Reply-To: <1409113308-4671-1-git-send-email-kostaslinuxxx@gmail.com>

At Tue, 26 Aug 2014 23:21:48 -0500,
Konstantinos Tsimpoukas wrote:
> 
> Adds to te readability of the ice1712 driver.
> 
> Signed-off-by: Konstantinos Tsimpoukas <kostaslinuxxx@gmail.com>

Thanks, applied.


Takashi

> ---
>  sound/pci/ice1712/ice1712.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/ice1712/ice1712.c b/sound/pci/ice1712/ice1712.c
> index 87f7fc4..206ed2c 100644
> --- a/sound/pci/ice1712/ice1712.c
> +++ b/sound/pci/ice1712/ice1712.c
> @@ -2528,7 +2528,7 @@ static int snd_ice1712_free(struct snd_ice1712 *ice)
>  	if (!ice->port)
>  		goto __hw_end;
>  	/* mask all interrupts */
> -	outb(0xc0, ICEMT(ice, IRQ));
> +	outb(ICE1712_MULTI_CAPTURE | ICE1712_MULTI_PLAYBACK, ICEMT(ice, IRQ));
>  	outb(0xff, ICEREG(ice, IRQMASK));
>  	/* --- */
>  __hw_end:
> -- 
> 1.9.1
> 

      reply	other threads:[~2014-08-27  6:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-27  4:21 [PATCH 1/1] ice1712: Replacing hex with #defines Konstantinos Tsimpoukas
2014-08-27  6:17 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hoav6foc5.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=kostaslinuxxx@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox