public inbox for linux-sound@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] ice1712: Replacing hex with #defines
@ 2014-08-27  4:21 Konstantinos Tsimpoukas
  2014-08-27  6:17 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Konstantinos Tsimpoukas @ 2014-08-27  4:21 UTC (permalink / raw)
  To: Konstantinos Tsimpoukas, alsa-devel
  Cc: Jaroslav Kysela, Takashi Iwai, linux-sound, linux-kernel

Adds to te readability of the ice1712 driver.

Signed-off-by: Konstantinos Tsimpoukas <kostaslinuxxx@gmail.com>
---
 sound/pci/ice1712/ice1712.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/ice1712/ice1712.c b/sound/pci/ice1712/ice1712.c
index 87f7fc4..206ed2c 100644
--- a/sound/pci/ice1712/ice1712.c
+++ b/sound/pci/ice1712/ice1712.c
@@ -2528,7 +2528,7 @@ static int snd_ice1712_free(struct snd_ice1712 *ice)
 	if (!ice->port)
 		goto __hw_end;
 	/* mask all interrupts */
-	outb(0xc0, ICEMT(ice, IRQ));
+	outb(ICE1712_MULTI_CAPTURE | ICE1712_MULTI_PLAYBACK, ICEMT(ice, IRQ));
 	outb(0xff, ICEREG(ice, IRQMASK));
 	/* --- */
 __hw_end:
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] ice1712: Replacing hex with #defines
  2014-08-27  4:21 [PATCH 1/1] ice1712: Replacing hex with #defines Konstantinos Tsimpoukas
@ 2014-08-27  6:17 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2014-08-27  6:17 UTC (permalink / raw)
  To: Konstantinos Tsimpoukas
  Cc: alsa-devel, Jaroslav Kysela, linux-sound, linux-kernel

At Tue, 26 Aug 2014 23:21:48 -0500,
Konstantinos Tsimpoukas wrote:
> 
> Adds to te readability of the ice1712 driver.
> 
> Signed-off-by: Konstantinos Tsimpoukas <kostaslinuxxx@gmail.com>

Thanks, applied.


Takashi

> ---
>  sound/pci/ice1712/ice1712.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/ice1712/ice1712.c b/sound/pci/ice1712/ice1712.c
> index 87f7fc4..206ed2c 100644
> --- a/sound/pci/ice1712/ice1712.c
> +++ b/sound/pci/ice1712/ice1712.c
> @@ -2528,7 +2528,7 @@ static int snd_ice1712_free(struct snd_ice1712 *ice)
>  	if (!ice->port)
>  		goto __hw_end;
>  	/* mask all interrupts */
> -	outb(0xc0, ICEMT(ice, IRQ));
> +	outb(ICE1712_MULTI_CAPTURE | ICE1712_MULTI_PLAYBACK, ICEMT(ice, IRQ));
>  	outb(0xff, ICEREG(ice, IRQMASK));
>  	/* --- */
>  __hw_end:
> -- 
> 1.9.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-08-27  6:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-27  4:21 [PATCH 1/1] ice1712: Replacing hex with #defines Konstantinos Tsimpoukas
2014-08-27  6:17 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox