Re: [PATCH v4 02/22] ASoC: dt-bindings: cs42l42: Allow referenced dai-common properties

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] ASoC: dt-bindings: cs42l42: unconstrained #sound-dai-cells property
--

commit f47243ba9c859acd0c0960da3d01089789ab4531
Author: James Calligeros <jcalligeros99@gmail.com>

ASoC: dt-bindings: cs42l42: Allow referenced dai-common properties

This patch updates the cirrus,cs42l42 DT binding schema to reference
dai-common.yaml and switch to unevaluatedProperties: false so that
#sound-dai-cells and sound-name-prefix can be used.

> diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs42l42.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs42l42.yaml
> index ab4c7d22dc0eb..4ac0af34c464b 100644
> --- a/Documentation/devicetree/bindings/sound/cirrus,cs42l42.yaml
> +++ b/Documentation/devicetree/bindings/sound/cirrus,cs42l42.yaml
> @@ -9,6 +9,9 @@ title: Cirrus Logic CS42L42 audio CODEC
>  maintainers:
>    - patches@opensource.cirrus.com
>  
> +allOf:
> +  - $ref: dai-common.yaml#
> +
>  description:
>    The CS42L42 is a low-power audio codec designed for portable applications.
>    It provides a high-dynamic range, stereo DAC for audio playback and a mono
> @@ -193,7 +196,7 @@ required:
>    - VL-supply
>    - VA-supply
>  
> -additionalProperties: false
> +unevaluatedProperties: false

[Severity: Low]
As reported by Krzysztof Kozlowski on v3 [1], should #sound-dai-cells be
constrained to const: 0 under properties in
Documentation/devicetree/bindings/sound/cirrus,cs42l42.yaml?

Because Documentation/devicetree/bindings/sound/dai-common.yaml only defines
#sound-dai-cells: true as a generic placeholder, referencing dai-common.yaml#
in allOf with unevaluatedProperties: false without listing #sound-dai-cells
under properties leaves the cell count unconstrained during schema
validation.

Meanwhile, cs42l42_common_probe() in sound/soc/codecs/cs42l42.c registers a
single DAI via devm_snd_soc_register_component(cs42l42->dev, component_drv,
dai, 1) and cs42l42_soc_component does not implement .of_xlate_dai_name, so
only #sound-dai-cells = <0> is supported by the driver.

[1] https://lore.kernel.org/r/20261019-overjoyed-outgoing-wren-4fdcc7@quoll

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103-macaudio-v4-0-637484efe46d@gmail.com?part=2