Re: [PATCH v4 13/22] arm64: dts: apple: t8103-j293: Add speaker/headset jack nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] arm64: dts: apple: unnecessary #address-cells/#size-cells in j293 sound node
- [Low] arm64: dts: apple: duplicate &i2c2 and root node blocks in t8103-j293.dts
--

commit 7afed482bafffba735ddfd1d14a91b354bbef084
Author: James Calligeros <jcalligeros99@gmail.com>

arm64: dts: apple: t8103-j293: Add speaker/headset jack nodes

This commit adds device tree nodes for the TI TAS5770L speaker amplifiers
and Cirrus Logic CS42L83 headset jack codec on the M1 MacBook Pro (J293),
and wires them up to the macaudio sound card node.

> diff --git a/arch/arm64/boot/dts/apple/t8103-j293.dts b/arch/arm64/boot/dts/apple/t8103-j293.dts
> index 1d074b9e60183..6980247b94e55 100644
> --- a/arch/arm64/boot/dts/apple/t8103-j293.dts
> +++ b/arch/arm64/boot/dts/apple/t8103-j293.dts
> @@ -133,5 +133,119 @@ &displaydfr_dart {

[ ... ]

> +&i2c2 {
> +	status = "okay";
> +
> +	jack_codec: codec@48 {

[Severity: Low]
This isn't a bug, but arch/arm64/boot/dts/apple/t8103-j293.dts already
has an earlier &i2c2 reference that sets status = "okay", as well as an
existing root / node at the top of the file:

arch/arm64/boot/dts/apple/t8103-j293.dts:
    / {
        compatible = "apple,j293", "apple,t8103", "apple,arm-platform";
        ...
    };
    ...
    &i2c2 {
        status = "okay";
    };

Could the earlier &i2c2 block be merged with this one and the sound node
placed into the existing root node to avoid duplicating both blocks in the
same file?

[ ... ]

> +/ {
> +	sound: sound {
> +		compatible = "apple,j293-macaudio";
> +		model = "MacBook Pro J293";
> +
> +		#address-cells = <1>;
> +		#size-cells = <0>;

[Severity: Low]
Does defining #address-cells and #size-cells in the sound node trigger a
dtc avoid_unnecessary_addr_size warning when building DTBs with W=1?

Although Documentation/devicetree/bindings/sound/apple,macaudio.yaml lists
#address-cells and #size-cells on the sound node, the child nodes
(headphone-dai-link and speaker-dai-link) do not have reg or ranges
properties, so check_avoid_unnecessary_addr_size() in scripts/dtc/checks.c
warns on this node under W=1.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103-macaudio-v4-0-637484efe46d@gmail.com?part=13