[PATCH v2] ASoC: amd: acp: Add support for more projects on ACP7.0

[PATCH v2] ASoC: amd: acp: Add support for more projects on ACP7.0

[Baojun Xu]

Add ACPI match table entries to support additional projects using the
TAS2783 codec on the ACP7.0 platform.

Signed-off-by: Baojun Xu <baojun.xu@ti.com>
---
v2:
 - Delete all entries whose link ID is greater than 2.
 - Remove all ASUS-related projects.
---
 sound/soc/amd/acp-config.c | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/sound/soc/amd/acp-config.c b/sound/soc/amd/acp-config.c
index 2fb9789cac0a..3d4c8526cfe2 100644
--- a/sound/soc/amd/acp-config.c
+++ b/sound/soc/amd/acp-config.c
@@ -98,6 +98,41 @@ static const struct dmi_system_id acp70_acpi_flag_override_table[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "8EA2"),
 		},
 	},
+	{
+		/* HP Cashmere-A */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "HP"),
+			DMI_MATCH(DMI_BOARD_NAME, "8EF5"),
+		},
+	},
+	{
+		/* HP Sundae */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "HP"),
+			DMI_MATCH(DMI_BOARD_NAME, "8F6D"),
+		},
+	},
+	{
+		/* HP SundaeWhip UMA */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "HP"),
+			DMI_MATCH(DMI_BOARD_NAME, "8FA4"),
+		},
+	},
+	{
+		/* HP SundaeWhip DSC */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "HP"),
+			DMI_MATCH(DMI_BOARD_NAME, "8FA5"),
+		},
+	},
+	{
+		/* HP Kata-A */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "HP"),
+			DMI_MATCH(DMI_BOARD_NAME, "9056"),
+		},
+	},
 	{
 		/* Dell 14S DS14265 */
 		.matches = {
-- 
2.25.1

Re: [PATCH v2] ASoC: amd: acp: Add support for more projects on ACP7.0

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] ASoC: amd: acp: commit message claims ACPI match entries for DMI table change
--

commit fa5635df62bd36367cf6a3d7f3a836d806c320e3
Author: Baojun Xu <baojun.xu@ti.com>

ASoC: amd: acp: Add support for more projects on ACP7.0

This commit adds five HP board DMI match entries to
acp70_acpi_flag_override_table in sound/soc/amd/acp-config.c.

>     ASoC: amd: acp: Add support for more projects on ACP7.0
>     
>     Add ACPI match table entries to support additional projects using the
>     TAS2783 codec on the ACP7.0 platform.
>     
>     Signed-off-by: Baojun Xu <baojun.xu@ti.com>

[Severity: Medium]
This isn't a bug in the code, but is this commit message accurate after the
v2 changes?

All of the ACPI SoundWire match table entries appear to have been dropped in
v2, and the patch now only adds five HP DMI board entries (8EF5, 8F6D, 8FA4,
8FA5, and 9056) to acp70_acpi_flag_override_table in
sound/soc/amd/acp-config.c.

In snd_amd_acp_find_config(), acp70_acpi_flag_override_table is checked via
dmi_check_system() to bypass snd_amd_acp_acpi_find_config() and return 0:

sound/soc/amd/acp-config.c:snd_amd_acp_find_config() {
	...
	else if (pci->revision >= ACP_7_0_REV) {
		if (dmi_check_system(acp70_acpi_flag_override_table))
			return 0;
		return snd_amd_acp_acpi_find_config(pci);
	}
	...
}

Should the commit message be updated to describe adding DMI flag-override
entries to acp70_acpi_flag_override_table for these HP boards and explain why
the BIOS acp-audio-config-flag ACPI property needs to be overridden on these
systems?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103131755.1558-1-baojun.xu@ti.com?part=1

Re: [PATCH v2] ASoC: amd: acp: Add support for more projects on ACP7.0

[Mark Brown]

On Tue, 03 Nov 2026 21:17:55 +0800, Baojun Xu wrote:
> ASoC: amd: acp: Add support for more projects on ACP7.0

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.4

Thanks!

[1/1] ASoC: amd: acp: Add support for more projects on ACP7.0
      https://git.kernel.org/broonie/sound/c/a08578200344

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark