Re: [PATCH 02/20] ASoC: soc-component: rename snd_soc_component_{init/exit}_regmap() to snd_soc_component_regmap_{init/exit}()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] ASoC: soc-component: build failure in
  snd_soc_component_regmap_exit() when !CONFIG_REGMAP
--

commit b2a7793f33b0c23793a100c7c2aba1692324766a
Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

ASoC: soc-component: rename snd_soc_component_{init/exit}_regmap() to snd_soc_component_regmap_{init/exit}()

This commit renames snd_soc_component_{init,exit}_regmap() to
snd_soc_component_regmap_{init,exit}(), provides compatibility macros for
the old names, and removes the #ifdef CONFIG_REGMAP guards around them.

> diff --git a/sound/soc/soc-component.c b/sound/soc/soc-component.c
> index a6e280c798f3d..6dad994009bdb 100644
> --- a/sound/soc/soc-component.c
> +++ b/sound/soc/soc-component.c
> @@ -432,10 +432,8 @@ void snd_soc_component_regmap_async_complete(struct snd_soc_component *component
>  }
>  EXPORT_SYMBOL_GPL(snd_soc_component_regmap_async_complete);
>  
> -#ifdef CONFIG_REGMAP
> -
>  /**
> - * snd_soc_component_init_regmap() - Initialize regmap instance for the
> + * snd_soc_component_regmap_init() - Initialize regmap instance for the
>   *                                   component
>   * @component: The component for which to initialize the regmap instance
>   * @regmap: The regmap instance that should be used by the component
> @@ -445,15 +443,15 @@ EXPORT_SYMBOL_GPL(snd_soc_component_regmap_async_complete);
>   * yet ready when the component is registered. The function must also be called
>   * before the first IO attempt of the component.
>   */
> -void snd_soc_component_init_regmap(struct snd_soc_component *component,
> +void snd_soc_component_regmap_init(struct snd_soc_component *component,
>  				   struct regmap *regmap)
>  {
>  	component->regmap = regmap;
>  }
> -EXPORT_SYMBOL_GPL(snd_soc_component_init_regmap);
> +EXPORT_SYMBOL_GPL(snd_soc_component_regmap_init);
>  
>  /**
> - * snd_soc_component_exit_regmap() - De-initialize regmap instance for the
> + * snd_soc_component_regmap_exit() - De-initialize regmap instance for the
>   *                                   component
>   * @component: The component for which to de-initialize the regmap instance
>   *
> @@ -463,14 +461,12 @@ EXPORT_SYMBOL_GPL(snd_soc_component_init_regmap);
>   * This function should only be used if snd_soc_component_init_regmap() was used
>   * to initialize the regmap instance.
>   */
> -void snd_soc_component_exit_regmap(struct snd_soc_component *component)
> +void snd_soc_component_regmap_exit(struct snd_soc_component *component)
>  {
>  	regmap_exit(component->regmap);
>  	component->regmap = NULL;
>  }
> -EXPORT_SYMBOL_GPL(snd_soc_component_exit_regmap);
> -
> -#endif
> +EXPORT_SYMBOL_GPL(snd_soc_component_regmap_exit);

[Severity: Medium]
Does removing the #ifdef CONFIG_REGMAP guard around
snd_soc_component_regmap_exit() break builds when CONFIG_SND_SOC is
enabled and CONFIG_REGMAP is disabled?

In sound/soc/Kconfig, SND_SOC only selects REGMAP_I2C if I2C and
REGMAP_SPI if SPI_MASTER, so CONFIG_REGMAP can remain unset.  Unlike
regmap_get_val_bytes(), regcache_sync(), and regmap_async_complete(),
regmap_exit() is only declared inside the #ifdef CONFIG_REGMAP block in
include/linux/regmap.h and has no stub when CONFIG_REGMAP is disabled,
causing an implicit function declaration error here.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/878q31nttj.wl-kuninori.morimoto.gx@renesas.com?part=2