Re: [PATCH 12/20] ASoC: soc-component: add snd_soc_component_to_regmap()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] ASoC: soc-component: snd_soc_component_to_regmap() ordered
  after its callers
--

commit 1b181762257030814f72c0850502aed04e2f536a
Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

ASoC: soc-component: add snd_soc_component_to_regmap()

This commit adds the snd_soc_component_to_regmap() helper function to
retrieve the regmap pointer from struct snd_soc_component.

> diff --git a/include/sound/soc-component.h b/include/sound/soc-component.h
> index 3ba4e2c84e4b4..4a72cfb5401a9 100644
> --- a/include/sound/soc-component.h
> +++ b/include/sound/soc-component.h
> @@ -278,6 +278,7 @@ const struct snd_soc_component_driver
>  *snd_soc_component_to_driver(struct snd_soc_component *component);
>  struct snd_soc_card *snd_soc_component_to_card(struct snd_soc_component *component);
>  struct dentry *snd_soc_component_to_debugfs_root(struct snd_soc_component *component);
> +struct regmap *snd_soc_component_to_regmap(struct snd_soc_component *component);
>  struct snd_soc_component *snd_soc_component_new(struct device *dev, const char *name,
>  						const struct snd_soc_component_driver *driver);
>  int snd_soc_component_register(struct snd_soc_component *component,
> diff --git a/sound/soc/soc-component.c b/sound/soc/soc-component.c
> index ebeac81355901..d8274273bb013 100644
> --- a/sound/soc/soc-component.c
> +++ b/sound/soc/soc-component.c
> @@ -92,6 +92,12 @@ struct dentry *snd_soc_component_to_debugfs_root(struct snd_soc_component *compo
>  }
>  EXPORT_SYMBOL_GPL(snd_soc_component_to_debugfs_root);
>  
> +struct regmap *snd_soc_component_to_regmap(struct snd_soc_component *component)
> +{
> +	return component->regmap;
> +}
> +EXPORT_SYMBOL_GPL(snd_soc_component_to_regmap);

[Severity: Medium]
Should this patch be ordered before commit "ASoC: soc-component: makes
regmap function to inline macro" in the series?

That earlier commit converts snd_soc_component_regmap_get_val_bytes() and
related helpers in include/sound/soc-component.h into static inline
functions that call snd_soc_component_to_regmap(), so the six intermediate
commits fail to compile with an implicit function declaration error and
break git bisect.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/878q31nttj.wl-kuninori.morimoto.gx@renesas.com?part=12