[PATCH] ASoC: qcom: common: report line-out plugs on the Headphone Jack pin

[PATCH] ASoC: qcom: common: report line-out plugs on the Headphone Jack pin

[Ingo A. Kubbilun]

The WCD MBHC classifies high-impedance loads (above linein_th, 5 kOhm
on wcd938x) such as active speakers as SND_JACK_LINEOUT. The
"Headphone Jack" pin only matched SND_JACK_HEADPHONE, so the jack
control stayed off and userspace (UCM JackControl) never switched to
the headphone output for those loads.

Seen on ASUS Vivobook S16 S3607QA (X1P42100, WCD9385): active
speakers measured at ~20 kOhm per channel were reported as LINEOUT only.

Developed with the help of an AI coding assistant (Anthropic Claude),
which drafted the changes from the Windows ACPI tables, existing device
trees and test logs; reviewed, built and tested on the device by the
submitter.

Signed-off-by: Ingo A. Kubbilun <ingo.kubbilun@gmail.com>
---
 sound/soc/qcom/common.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/sound/soc/qcom/common.c b/sound/soc/qcom/common.c
index 5dc954dc1cb2..af5cacddf67d 100644
--- a/sound/soc/qcom/common.c
+++ b/sound/soc/qcom/common.c
@@ -335,7 +335,11 @@ static struct snd_soc_jack_pin qcom_headset_jack_pins[] = {
 	},
 	{
 		.pin = "Headphone Jack",
-		.mask = SND_JACK_HEADPHONE,
+		/*
+		 * WCD MBHC reports loads above linein_th (5 kOhm) as LINEOUT,
+		 * e.g. active speakers; treat them like headphones for routing.
+		 */
+		.mask = SND_JACK_HEADPHONE | SND_JACK_LINEOUT,
 	},
 };
 
-- 
2.47.3

Re: [PATCH] ASoC: qcom: common: report line-out plugs on the Headphone Jack pin

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ASoC: qcom: common: missing Fixes trailer for
  qcom_headset_jack_pins
--

commit 0fd555bd073d8d5bb7f8b16e45526f52c4eac77a
Author: Ingo A. Kubbilun <ingo.kubbilun@gmail.com>

> ASoC: qcom: common: report line-out plugs on the Headphone Jack pin
>
> The WCD MBHC classifies high-impedance loads (above linein_th, 5 kOhm
> on wcd938x) such as active speakers as SND_JACK_LINEOUT. The
> "Headphone Jack" pin only matched SND_JACK_HEADPHONE, so the jack
> control stayed off and userspace (UCM JackControl) never switched to
> the headphone output for those loads.
>
> Seen on ASUS Vivobook S16 S3607QA (X1P42100, WCD9385): active
> speakers measured at ~20 kOhm per channel were reported as LINEOUT only.
>
> Developed with the help of an AI coding assistant (Anthropic Claude),
> which drafted the changes from the Windows ACPI tables, existing device
> trees and test logs; reviewed, built and tested on the device by the
> submitter.
>
> Signed-off-by: Ingo A. Kubbilun <ingo.kubbilun@gmail.com>

[Severity: Low]
This fixes the "Headphone Jack" pin mask in qcom_headset_jack_pins[],
which omitted SND_JACK_LINEOUT when jack pins were added.  Should the
commit message include:

  Fixes: 4c2c935a278e ("ASoC: qcom: common: add kcontrol to jack pins")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113214544.232836-1-ingo.kubbilun@gmail.com?part=1