Linux Sound subsystem development
 help / color / mirror / Atom feed
* [PATCH] ASoC: amd: yc: Add DMI quirk for GIGABYTE EAGLE 9MJ
@ 2026-11-15 23:29 Adolfo Morales Tena
  2026-11-15 23:34 ` sashiko-bot
  2026-11-16  2:55 ` Mukunda,Vijendar
  0 siblings, 2 replies; 3+ messages in thread
From: Adolfo Morales Tena @ 2026-11-15 23:29 UTC (permalink / raw)
  To: linux-sound, broonie, lgirdwood, Vijendar.Mukunda
  Cc: venkataprasad.potturu, perex, tiwai, linux-kernel,
	Adolfo Morales Tena

The GIGABYTE EAGLE 9MJ has a digital microphone connected to the
ACP6x PDM controller, but it is not listed in the quirk table. As a
result the machine driver does not register the sound card and the
internal microphone is unusable.

Add a DMI entry to enable the DMIC. With it, the acp6x card is
registered and the internal microphone records correctly. The kernel
log shows:

  acp_yc_mach acp_yc_mach.0: Enabling ACP DMIC support via DMI

Signed-off-by: Adolfo Morales Tena <spidermanadolfo@gmail.com>
---
 sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index e14c73e7e..f636b5ba5 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -969,6 +969,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "TUF Gaming A16 FA607NUQ"),
 		}
 	},
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "GIGABYTE"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "GIGABYTE EAGLE 9MJ"),
+		}
+	},
 	{}
 };
 
-- 
2.56.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: amd: yc: Add DMI quirk for GIGABYTE EAGLE 9MJ
  2026-11-15 23:29 [PATCH] ASoC: amd: yc: Add DMI quirk for GIGABYTE EAGLE 9MJ Adolfo Morales Tena
@ 2026-11-15 23:34 ` sashiko-bot
  2026-11-16  2:55 ` Mukunda,Vijendar
  1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-11-15 23:34 UTC (permalink / raw)
  To: Adolfo Morales Tena, linux-sound

Thank you for your contribution! Sashiko AI review found no new issues
in this patch, but noticed 1 related pre-existing issue it does not
introduce:
- [High] ASoC: amd: yc: bypassed AcpDmicConnected check in acp6x_probe()
  [1]
--

commit e897ced0b25eb47667a9260d248834825a1643ca
Author: Adolfo Morales Tena <spidermanadolfo@gmail.com>

ASoC: amd: yc: Add DMI quirk for GIGABYTE EAGLE 9MJ

This commit adds a DMI quirk entry for the GIGABYTE EAGLE 9MJ to
yc_acp_quirk_table to enable internal DMIC support.

> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index e14c73e7e988a..f636b5ba5b072 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -969,6 +969,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "TUF Gaming A16 FA607NUQ"),
>  		}
>  	},
> +	{
> +		.driver_data = &acp6x_card,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "GIGABYTE"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "GIGABYTE EAGLE 9MJ"),
> +		}
> +	},
>  	{}
>  };

[Severity: High]
This problem wasn't introduced by this patch, but does acp6x_probe()
bypass the is_dmic_enable check when the _WOV ACPI method is missing
[1]?

sound/soc/amd/yc/acp6x-mach.c:acp6x_probe() {
	...
	ret = acpi_evaluate_integer(handle, "_WOV", NULL, &dmic_status);
	if (!ACPI_FAILURE(ret)) {
		wov_en = dmic_status;
		if (!wov_en)
			goto check_dmi_entry;
	} else {
		/* Incase of ACPI method read failure then jump to check_dmi_entry */
		goto check_dmi_entry;
	}

	if (is_dmic_enable)
		platform_set_drvdata(pdev, &acp6x_card);

check_dmi_entry:
	/* check for any DMI overrides */
	dmi_id = dmi_first_match(yc_acp_quirk_table);
	...
}

When a BIOS sets the AcpDmicConnected _DSD property to 1 (setting
is_dmic_enable = true) but omits the _WOV method, acpi_evaluate_integer()
fails and the else branch jumps directly to check_dmi_entry.  That skips
binding acp6x_card from is_dmic_enable, so unless the machine is also
listed in yc_acp_quirk_table, platform_get_drvdata() returns NULL and
acp6x_probe() fails with -ENODEV.

[1] https://sashiko.dev/#/bug/linux-9da65c71-a54c-4d66-b1a8-325c916b74d6

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261115232942.5820-1-spidermanadolfo@gmail.com?part=1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: amd: yc: Add DMI quirk for GIGABYTE EAGLE 9MJ
  2026-11-15 23:29 [PATCH] ASoC: amd: yc: Add DMI quirk for GIGABYTE EAGLE 9MJ Adolfo Morales Tena
  2026-11-15 23:34 ` sashiko-bot
@ 2026-11-16  2:55 ` Mukunda,Vijendar
  1 sibling, 0 replies; 3+ messages in thread
From: Mukunda,Vijendar @ 2026-11-16  2:55 UTC (permalink / raw)
  To: Adolfo Morales Tena, linux-sound, broonie, lgirdwood
  Cc: venkataprasad.potturu, perex, tiwai, linux-kernel



On 11/16/26 04:59, Adolfo Morales Tena wrote:
> [You don't often get email from spidermanadolfo@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> The GIGABYTE EAGLE 9MJ has a digital microphone connected to the
> ACP6x PDM controller, but it is not listed in the quirk table. As a
> result the machine driver does not register the sound card and the
> internal microphone is unusable.
>
> Add a DMI entry to enable the DMIC. With it, the acp6x card is
> registered and the internal microphone records correctly. The kernel
> log shows:
>
>    acp_yc_mach acp_yc_mach.0: Enabling ACP DMIC support via DMI
>
> Signed-off-by: Adolfo Morales Tena <spidermanadolfo@gmail.com>
Reviewed-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> ---
>   sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index e14c73e7e..f636b5ba5 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -969,6 +969,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
>                          DMI_MATCH(DMI_PRODUCT_NAME, "TUF Gaming A16 FA607NUQ"),
>                  }
>          },
> +       {
> +               .driver_data = &acp6x_card,
> +               .matches = {
> +                       DMI_MATCH(DMI_BOARD_VENDOR, "GIGABYTE"),
> +                       DMI_MATCH(DMI_PRODUCT_NAME, "GIGABYTE EAGLE 9MJ"),
> +               }
> +       },
>          {}
>   };
>
> --
> 2.56.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-16  2:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-15 23:29 [PATCH] ASoC: amd: yc: Add DMI quirk for GIGABYTE EAGLE 9MJ Adolfo Morales Tena
2026-11-15 23:34 ` sashiko-bot
2026-11-16  2:55 ` Mukunda,Vijendar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox