Linux SPARSE checker discussions
 help / color / mirror / Atom feed
* [PATCH] cgcc: provide __ARM_PCS_VFP for armhf
@ 2017-09-26  7:15 Uwe Kleine-König
  2017-09-26 20:35 ` Luc Van Oostenryck
  0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König @ 2017-09-26  7:15 UTC (permalink / raw)
  To: linux-sparse

This fixes:

	$ uname -m
	armv8l
	$ env CHECK=./sparse ./cgcc -no-compile memops.c
	/usr/include/arm-linux-gnueabihf/gnu/stubs.h:7:12: error: unable to open 'gnu/stubs-soft.h'

Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
---
Hello,

I added

	env CHECK=./sparse ./cgcc -no-compile memops.c

to the package building process and that failed on armhf (i.e.  Armv7
CPU with Thumb-2 and VFP3D16 or better) with the above error.

With that applied all Debian primary architectures work fine; see
https://buildd.debian.org/status/package.php?p=sparse&suite=unstable

Best regards
Uwe

 cgcc | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/cgcc b/cgcc
index a8d7b4f..ee59201 100755
--- a/cgcc
+++ b/cgcc
@@ -296,7 +296,14 @@ sub add_specs {
 		&define_size_t ("long unsigned int") .
 		' -D__SIZEOF_POINTER__=' . ($m64 ? '8' : '4'));
     } elsif ($spec eq 'arm') {
-	return (' -D__arm__=1 -m32' .
+	chomp (my $gccmachine = `$cc -dumpmachine`);
+	my $cppsymbols = ' -D__arm__=1 -m32';
+
+	if ($gccmachine eq 'arm-linux-gnueabihf') {
+	    $cppsymbols .= ' -D__ARM_PCS_VFP=1';
+	}
+
+	return ($cppsymbols .
 		&float_types (1, 1, 36, [24,8], [53,11], [53, 11]));
     } elsif ($spec eq 'aarch64') {
 	return (' -D__aarch64__=1 -m64' .
@@ -324,7 +331,7 @@ sub add_specs {
 	    return &add_specs ('s390x');
 	} elsif ($arch =~ /^(sparc64)$/i) {
 	    return &add_specs ('sparc64');
-	} elsif ($arch =~ /^(arm)$/i) {
+	} elsif ($arch =~ /^arm(?:v[78]l)?$/i) {
 	    return &add_specs ('arm');
 	} elsif ($arch =~ /^(aarch64)$/i) {
 	    return &add_specs ('aarch64');
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] cgcc: provide __ARM_PCS_VFP for armhf
  2017-09-26  7:15 [PATCH] cgcc: provide __ARM_PCS_VFP for armhf Uwe Kleine-König
@ 2017-09-26 20:35 ` Luc Van Oostenryck
  0 siblings, 0 replies; 2+ messages in thread
From: Luc Van Oostenryck @ 2017-09-26 20:35 UTC (permalink / raw)
  To: Uwe Kleine-König; +Cc: linux-sparse

On Tue, Sep 26, 2017 at 09:15:20AM +0200, Uwe Kleine-König wrote:
> This fixes:
> 
> 	$ uname -m
> 	armv8l
> 	$ env CHECK=./sparse ./cgcc -no-compile memops.c
> 	/usr/include/arm-linux-gnueabihf/gnu/stubs.h:7:12: error: unable to open 'gnu/stubs-soft.h'
> 
...
> 
> With that applied all Debian primary architectures work fine; see
> https://buildd.debian.org/status/package.php?p=sparse&suite=unstable

Nice!
 
-- Luc

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-09-26 20:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-26  7:15 [PATCH] cgcc: provide __ARM_PCS_VFP for armhf Uwe Kleine-König
2017-09-26 20:35 ` Luc Van Oostenryck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox