[PATCH] add __builtin functions for isinf_sign, isfinite and isnan

[PATCH] add __builtin functions for isinf_sign, isfinite and isnan

[Logan Gunthorpe]

These bultins are defined by in gcc since 4.4. They are also now
used by the isinf, isfinite and isnan macros. So using them with a
newer gcc causes 'undefined identifier' errors.

Add the builtin definitions and some validation checks for these
functions.

Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
---
 lib.c                    | 3 +++
 validation/builtin_inf.c | 8 ++++++++
 2 files changed, 11 insertions(+)

diff --git a/lib.c b/lib.c
index 4602cf8..cc740e9 100644
--- a/lib.c
+++ b/lib.c
@@ -1105,6 +1105,9 @@ void declare_builtin_functions(void)
 	add_pre_buffer("extern double __builtin_nan(const char *);\n");
 	add_pre_buffer("extern float __builtin_nanf(const char *);\n");
 	add_pre_buffer("extern long double __builtin_nanl(const char *);\n");
+	add_pre_buffer("extern int __builtin_isinf_sign(float);\n");
+	add_pre_buffer("extern int __builtin_isfinite(float);\n");
+	add_pre_buffer("extern int __builtin_isnan(float);\n");
 
 	/* And some __FORTIFY_SOURCE ones.. */
 	add_pre_buffer ("extern __SIZE_TYPE__ __builtin_object_size(const void *, int);\n");
diff --git a/validation/builtin_inf.c b/validation/builtin_inf.c
index 48546e4..0855ab0 100644
--- a/validation/builtin_inf.c
+++ b/validation/builtin_inf.c
@@ -7,6 +7,14 @@ static long double li = __builtin_infl();
 static double dn = __builtin_nan("");
 static float fn = __builtin_nanf("");
 static long double ln = __builtin_nanl("");
+static int inf = __builtin_isinf_sign(0.0);
+static int fin = __builtin_isfinite(0.0);
+static int nan = __builtin_isnan(0.0);
+
+#include <math.h>
+static int inf2 = isinf(0.0);
+static int fin2 = isfinite(0.0);
+static int nan2 = isnan(0.0);
 
 /*
  * check-name: __builtin INFINITY / nan()
-- 
2.11.0

Re: [PATCH] add __builtin functions for isinf_sign, isfinite and isnan

[Christopher Li]

On Fri, Nov 17, 2017 at 5:27 AM, Logan Gunthorpe <logang@deltatee.com> wrote:
> These bultins are defined by in gcc since 4.4. They are also now
> used by the isinf, isfinite and isnan macros. So using them with a
> newer gcc causes 'undefined identifier' errors.
>
> Add the builtin definitions and some validation checks for these
> functions.

Thanks for the patch.

> diff --git a/validation/builtin_inf.c b/validation/builtin_inf.c
> index 48546e4..0855ab0 100644
> --- a/validation/builtin_inf.c
> +++ b/validation/builtin_inf.c
> @@ -7,6 +7,14 @@ static long double li = __builtin_infl();
>  static double dn = __builtin_nan("");
>  static float fn = __builtin_nanf("");
>  static long double ln = __builtin_nanl("");
> +static int inf = __builtin_isinf_sign(0.0);
> +static int fin = __builtin_isfinite(0.0);
> +static int nan = __builtin_isnan(0.0);
> +
> +#include <math.h>

Can you remove the <math.h>?

For the validation test, it would be best to not depend on
system header file. You can use sparse -E to dig out the
related function call after the pre-process.

Other than that, it looks good.

I want to apply with the math.h removed.

Chris