From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Alexey Gladkov <gladkov.alexey@gmail.com>, linux-sparse@vger.kernel.org
Subject: Re: [PATCH] dissect: introduce sym_is_local() for reporter
Date: Wed, 12 Feb 2020 01:41:35 +0100 [thread overview]
Message-ID: <20200212004135.cyzcqtwwcuewa4gj@ltop.local> (raw)
In-Reply-To: <20200211160136.GA14027@redhat.com>
On Tue, Feb 11, 2020 at 05:01:36PM +0100, Oleg Nesterov wrote:
> Can be used to filter out the usage of local variables.
...
> diff --git a/dissect.h b/dissect.h
> index efe2c0b..178dba5 100644
> --- a/dissect.h
> +++ b/dissect.h
> @@ -27,6 +27,11 @@ struct reporter
>
> extern struct symbol *dissect_ctx;
>
> +static inline bool sym_is_local(struct symbol *sym)
> +{
> + return sym->kind == 'v' && !(sym->ctype.modifiers & MOD_TOPLEVEL);
> +}
> +
Shouldn't MOD_STATIC be added to the test?
It depends on what exactly you want for 'local'.
-- Luc
next prev parent reply other threads:[~2020-02-12 0:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 16:01 [PATCH] dissect: introduce sym_is_local() for reporter Oleg Nesterov
2020-02-12 0:41 ` Luc Van Oostenryck [this message]
2020-02-12 9:06 ` Oleg Nesterov
2020-02-13 17:41 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212004135.cyzcqtwwcuewa4gj@ltop.local \
--to=luc.vanoostenryck@gmail.com \
--cc=gladkov.alexey@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox