From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Alexey Gladkov <gladkov.alexey@gmail.com>, linux-sparse@vger.kernel.org
Subject: Re: [PATCH] dissect: introduce sym_is_local() for reporter
Date: Thu, 13 Feb 2020 18:41:30 +0100 [thread overview]
Message-ID: <20200213174130.vzc3tj3l3dj3xrpc@ltop.local> (raw)
In-Reply-To: <20200212090626.GA19406@redhat.com>
On Wed, Feb 12, 2020 at 10:06:27AM +0100, Oleg Nesterov wrote:
> On 02/12, Luc Van Oostenryck wrote:
> > It depends on what exactly you want for 'local'.
>
> Yes, it should only return T if the symbol was defined inside some function.
> If we have
>
> static int I;
>
> in file scope, sym_is_local() should return false and so it does, test-dissect
> outputs
>
> 1:12 def v I int
OK, then everything is fine.
> Thanks for looking!
You're welcome!
This and the other pending ones are now pushed to main.
-- Luc
prev parent reply other threads:[~2020-02-13 17:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 16:01 [PATCH] dissect: introduce sym_is_local() for reporter Oleg Nesterov
2020-02-12 0:41 ` Luc Van Oostenryck
2020-02-12 9:06 ` Oleg Nesterov
2020-02-13 17:41 ` Luc Van Oostenryck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213174130.vzc3tj3l3dj3xrpc@ltop.local \
--to=luc.vanoostenryck@gmail.com \
--cc=gladkov.alexey@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox