From: Mark Brown <broonie@kernel.org>
To: Jonathan Marek <jonathan@marek.ca>,
konrad.dybcio@oss.qualcomm.com,
Maramaina Naresh <naresh.maramaina@oss.qualcomm.com>
Cc: kernel@quicinc.com, linux-arm-msm@vger.kernel.org,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, dmitry.baryshkov@oss.qualcomm.com,
bjorande@quicinc.com, mukesh.savaliya@oss.qualcomm.com,
praveen.talari@oss.qualcomm.com,
jyothi.seerapu@oss.qualcomm.com
Subject: Re: [PATCH v1] spi: geni-qcom: Fix CPHA and CPOL mode change detection
Date: Mon, 16 Mar 2026 17:52:59 +0000 [thread overview]
Message-ID: <177368357914.147197.2736857067753744270.b4-ty@kernel.org> (raw)
In-Reply-To: <20260316-spi-geni-cpha-cpol-fix-v1-1-4cb44c176b79@oss.qualcomm.com>
On Mon, 16 Mar 2026 18:53:31 +0530, Maramaina Naresh wrote:
> setup_fifo_params computes mode_changed from spi->mode flags but tests
> it against SE_SPI_CPHA and SE_SPI_CPOL, which are register offsets,
> not SPI mode bits. This causes CPHA and CPOL updates to be skipped
> on mode switches, leaving the controller with stale clock phase
> and polarity settings.
>
> Fix this by using SPI_CPHA and SPI_CPOL to detect mode changes before
> updating the corresponding registers.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: geni-qcom: Fix CPHA and CPOL mode change detection
https://git.kernel.org/broonie/misc/c/ba3402f6c85b
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
prev parent reply other threads:[~2026-03-16 17:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 13:23 [PATCH v1] spi: geni-qcom: Fix CPHA and CPOL mode change detection Maramaina Naresh
2026-03-16 13:28 ` Konrad Dybcio
2026-03-16 14:48 ` Mark Brown
2026-03-16 17:13 ` Jonathan Marek
2026-03-21 3:04 ` Val Packett
2026-03-16 17:52 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177368357914.147197.2736857067753744270.b4-ty@kernel.org \
--to=broonie@kernel.org \
--cc=bjorande@quicinc.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=jonathan@marek.ca \
--cc=jyothi.seerapu@oss.qualcomm.com \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mukesh.savaliya@oss.qualcomm.com \
--cc=naresh.maramaina@oss.qualcomm.com \
--cc=praveen.talari@oss.qualcomm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox