From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Geert Uytterhoeven
<geert+renesas-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Subject: Re: [PATCH/RFC] spi: core: Fix logic mismatch in spi_master.set_cs()
Date: Tue, 14 Jan 2014 12:52:42 +0000 [thread overview]
Message-ID: <20140114125242.GE15567@sirena.org.uk> (raw)
In-Reply-To: <1389699411-29135-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 693 bytes --]
On Tue, Jan 14, 2014 at 12:36:51PM +0100, Geert Uytterhoeven wrote:
> {
> - if (spi->mode & SPI_CS_HIGH)
> - enable = !enable;
> -
> - if (spi->cs_gpio >= 0)
> + if (spi->cs_gpio >= 0) {
> + if (spi->mode & SPI_CS_HIGH)
> + enable = !enable;
> gpio_set_value(spi->cs_gpio, !enable);
> - else if (spi->master->set_cs)
> - spi->master->set_cs(spi, !enable);
> + } else if (spi->master->set_cs)
> + spi->master->set_cs(spi, enable);
> }
Coding style, braces on all branches of an if statement.
This also pushes the handling of CS_HIGH back out into the driver which
doesn't seem like it's helping anything. Flipping the sense of enable
when calling set_cs() is probably OK though.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-14 12:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 11:36 [PATCH/RFC] spi: core: Fix logic mismatch in spi_master.set_cs() Geert Uytterhoeven
[not found] ` <1389699411-29135-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2014-01-14 12:52 ` Mark Brown [this message]
[not found] ` <20140114125242.GE15567-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-01-14 13:23 ` Geert Uytterhoeven
[not found] ` <CAMuHMdVmSUh8yphZ4oPR=QYp5uMS9BXgPRVuwa19S9q7jWxxiQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-01-14 13:45 ` Mark Brown
2014-01-14 14:44 ` Geert Uytterhoeven
[not found] ` <CAMuHMdXEsNKRxYv8gh5sDzpg_QH2RmrjYhLhCZx0QCcRN+gdOg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-01-14 14:50 ` Mark Brown
[not found] ` <20140114145002.GR15567-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-01-14 15:18 ` Geert Uytterhoeven
[not found] ` <CAMuHMdVhmtA0ogEqu-jj8Kvii5CwV8qfHn+GzgQ9uFKzH7Ua6w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-01-17 18:03 ` Mark Brown
[not found] ` <20140117180304.GB17314-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-01-17 19:04 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140114125242.GE15567@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=geert+renesas-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
--cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox