From: Mark Brown <broonie@kernel.org>
To: Jonatas Rech <jonatas.rech@datacom.ind.br>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: fsl-espi: fix behaviour for full-duplex xfers
Date: Sat, 18 Apr 2015 13:55:56 +0100 [thread overview]
Message-ID: <20150418125556.GR26185@sirena.org.uk> (raw)
In-Reply-To: <1429111398-21444-1-git-send-email-jonatas.rech@datacom.ind.br>
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
On Wed, Apr 15, 2015 at 12:23:18PM -0300, Jonatas Rech wrote:
> Furthermore, this correction has exposed an inconsistency in the
> protocol driver <-> controller driver interaction. The spi-fsl-espi
> driver artificially inserts TX bytes when message fragmentation is
> necessary (due to SPCOM_TRANLEN_MAX) instead of informing the
> protocol driver of the hardware limitation. This was tested with the
> m25p80 NOR flash protocol driver. Since fixing this issue may cause
> other client drivers to malfunction, it was left as is.
Sorry, you're saying that the driver is sending more data than it's
being asked to in some situations? That is a *very* serious bug in both
this driver and any other driver which relies on (as opposed to merely
tolerates) this behaviour. If that is the case it really needs to be
fixed fairly urgently.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-04-18 12:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 15:23 [PATCH] spi: fsl-espi: fix behaviour for full-duplex xfers Jonatas Rech
2015-04-18 12:55 ` Mark Brown [this message]
[not found] ` <20150418125556.GR26185-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-04-22 15:09 ` DATACOM - Jonatas.Rech
2015-04-22 19:57 ` Mark Brown
[not found] ` <20150422195746.GM22845-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-04-23 18:06 ` Jonatas Rech
2015-04-24 18:17 ` Mark Brown
[not found] ` <20150424181745.GG22845-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-04-24 20:03 ` Jonatas Rech
[not found] ` <20150424200326.GA14443-rCUF4CxDseZknzVnJbg3IA@public.gmane.org>
2015-04-25 13:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150418125556.GR26185@sirena.org.uk \
--to=broonie@kernel.org \
--cc=jonatas.rech@datacom.ind.br \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox