From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jonatas Rech <jonatas.rech-rCUF4CxDseZknzVnJbg3IA@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] spi: fsl-espi: fix behaviour for full-duplex xfers
Date: Sat, 25 Apr 2015 14:01:24 +0100 [thread overview]
Message-ID: <20150425130124.GF31708@sirena.org.uk> (raw)
In-Reply-To: <20150424200326.GA14443-rCUF4CxDseZknzVnJbg3IA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 658 bytes --]
On Fri, Apr 24, 2015 at 05:03:26PM -0300, Jonatas Rech wrote:
> On Fri, Apr 24, 2015 at 07:17:45PM +0100, Mark Brown wrote:
> > The commit message says "this correction has exposed an inconsistency"
> > which suggests that the problem was masked before this fix. Did you
> > mean to say that while fixing this you noticed a separate bug that's
> > present anyway?
> Exactly. Besides fixing the full-duplex capability I reorganized things
> inside the main loop so that anybody can spot where the extra bytes are
> being sent, but the code works just the same as before in that respect.
OK, please be clear when writing changelogs - it makes life easier.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-04-25 13:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 15:23 [PATCH] spi: fsl-espi: fix behaviour for full-duplex xfers Jonatas Rech
2015-04-18 12:55 ` Mark Brown
[not found] ` <20150418125556.GR26185-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-04-22 15:09 ` DATACOM - Jonatas.Rech
2015-04-22 19:57 ` Mark Brown
[not found] ` <20150422195746.GM22845-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-04-23 18:06 ` Jonatas Rech
2015-04-24 18:17 ` Mark Brown
[not found] ` <20150424181745.GG22845-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-04-24 20:03 ` Jonatas Rech
[not found] ` <20150424200326.GA14443-rCUF4CxDseZknzVnJbg3IA@public.gmane.org>
2015-04-25 13:01 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150425130124.GF31708@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=jonatas.rech-rCUF4CxDseZknzVnJbg3IA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox