[PATCH] spi: spi-pxa2xx: Constify ACPI device ids

[PATCH] spi: spi-pxa2xx: Constify ACPI device ids

[Mathias Krause]

Constify the ACPI device ID array, it doesn't need to be writable at
runtime.

Signed-off-by: Mathias Krause <minipli-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
Cc: Daniel Mack <daniel-cYrQPVfZoowdnm+yROfE0A@public.gmane.org>
Cc: Haojian Zhuang <haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Robert Jarzmik <robert.jarzmik-GANU6spQydw@public.gmane.org>
---
This patch should go on top of spi.git#topic/pxa

 drivers/spi/spi-pxa2xx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
index f97cd42fbc22..7293d6d875c5 100644
--- a/drivers/spi/spi-pxa2xx.c
+++ b/drivers/spi/spi-pxa2xx.c
@@ -1265,7 +1265,7 @@ static void cleanup(struct spi_device *spi)
 
 #ifdef CONFIG_ACPI
 
-static struct acpi_device_id pxa2xx_spi_acpi_match[] = {
+static const struct acpi_device_id pxa2xx_spi_acpi_match[] = {
 	{ "INT33C0", LPSS_LPT_SSP },
 	{ "INT33C1", LPSS_LPT_SSP },
 	{ "INT3430", LPSS_LPT_SSP },
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] spi: spi-pxa2xx: Constify ACPI device ids

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

On Sat, Jun 13, 2015 at 02:22:14PM +0200, Mathias Krause wrote:
> Constify the ACPI device ID array, it doesn't need to be writable at
> runtime.

Applied, please do make an effort to CC relevant people working on the
code when contributing patches (I'm not seeing any of the people working
on the Intel platforms here and I'm at a bit of a loss why Rafael and
Len are in the CCs).

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH] spi: spi-pxa2xx: Constify ACPI device ids

[Mathias Krause]

On 15 June 2015 at 11:53, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Sat, Jun 13, 2015 at 02:22:14PM +0200, Mathias Krause wrote:
>> Constify the ACPI device ID array, it doesn't need to be writable at
>> runtime.
>
> Applied, please do make an effort to CC relevant people working on the
> code when contributing patches (I'm not seeing any of the people working
> on the Intel platforms here and I'm at a bit of a loss why Rafael and
> Len are in the CCs).

I used the list of people that are mentioned in the MAINTAINERS file:

PXA2xx/PXA3xx SUPPORT
M:  Daniel Mack <daniel-cYrQPVfZoowdnm+yROfE0A@public.gmane.org>
M:  Haojian Zhuang <haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
M:  Robert Jarzmik <robert.jarzmik-GANU6spQydw@public.gmane.org>
...
F:  drivers/spi/spi-pxa2xx*

Was that wrong? Who else should I've send the patch to? Maybe they
should be added to the MAINTAINERS file?

Rafael and Len are on Cc because of [1] -- an effort to constify all
users of struct acpi_device_id. They're on Cc because of the ACPI
relation. I hope that clears it up.

I was uncertain how to group those changes but tried to split them up
per-system. So you're seeing only the patches where you are mentioned
as a maintainer. I thought it would be less noise this way for the
non-ACPI related patches. It's a simple patch, after all.

[1] http://www.spinics.net/lists/linux-acpi/msg58593.html


Regards,
Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] spi: spi-pxa2xx: Constify ACPI device ids

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]

On Mon, Jun 15, 2015 at 07:47:37PM +0200, Mathias Krause wrote:

> Was that wrong? Who else should I've send the patch to? Maybe they
> should be added to the MAINTAINERS file?

I'd have expected at least Jarkko (who's been actively working on the
ACPI stuff for this driver) - in general MAINTAINERS is a bit
unreliable, you should probably glance at git log.

> Rafael and Len are on Cc because of [1] -- an effort to constify all
> users of struct acpi_device_id. They're on Cc because of the ACPI
> relation. I hope that clears it up.

Consider if every single patch adding a const to an ACPI ID list really
needs to go to the ACPI maintainers (I know I get a lot of really odd
stuff registering SPI devices).

> I was uncertain how to group those changes but tried to split them up
> per-system. So you're seeing only the patches where you are mentioned
> as a maintainer. I thought it would be less noise this way for the
> non-ACPI related patches. It's a simple patch, after all.

That bit is fine.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH] spi: spi-pxa2xx: Constify ACPI device ids

[Robert Jarzmik]

Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> writes:

> On Sat, Jun 13, 2015 at 02:22:14PM +0200, Mathias Krause wrote:
>> Constify the ACPI device ID array, it doesn't need to be writable at
>> runtime.
>
> Applied, please do make an effort to CC relevant people working on the
> code when contributing patches (I'm not seeing any of the people working
> on the Intel platforms here
Actually there is one working on Intel embedded devices, it's just that it's his
dark side, see "To:" of this mail with an unusual mail address :)

And Mathias, even if it's not obvious, and even obfuscated, look at this :
rj@belgarion:~/mio_linux/kernel$ scripts/get_maintainer.pl --rolestats --roles
--git-max-maintainers=10 --git-blame -f drivers/spi/spi-pxa2xx.c
  Stephen Street <stephen-nl6u4wocdmy51APUEpUfAkEOCMrvLtNR@public.gmane.org> (authored lines:553/1600=35%)
  Mika Westerberg <mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> (authored lines:321/1600=20%,commits:25/80=31%)

These are the top 2 authors.

All of this brings me to the next point : Mika, wouldn't you add yourself as
spi-pxa2xx maintainer ? I can't recall if it's for Edison or another platform,
but you contribute a lot to spi-pxa2xx, so wouldn't it make sense ?

Cheers.

--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] spi: spi-pxa2xx: Constify ACPI device ids

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 623 bytes --]

On Mon, Jun 15, 2015 at 09:12:22PM +0200, Robert Jarzmik wrote:

> Actually there is one working on Intel embedded devices, it's just that it's his
> dark side, see "To:" of this mail with an unusual mail address :)

Huh, I'd forgotten you were working for Intel now sorry - I was mainly
thinking of Mika and Jarkko here.  I did remember you used to work on
some of the PXA handhelds!

> All of this brings me to the next point : Mika, wouldn't you add yourself as
> spi-pxa2xx maintainer ? I can't recall if it's for Edison or another platform,
> but you contribute a lot to spi-pxa2xx, so wouldn't it make sense ?

Yeah.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH] spi: spi-pxa2xx: Constify ACPI device ids

[Mika Westerberg]

On Mon, Jun 15, 2015 at 08:20:25PM +0100, Mark Brown wrote:
> On Mon, Jun 15, 2015 at 09:12:22PM +0200, Robert Jarzmik wrote:
> 
> > Actually there is one working on Intel embedded devices, it's just that it's his
> > dark side, see "To:" of this mail with an unusual mail address :)
> 
> Huh, I'd forgotten you were working for Intel now sorry - I was mainly
> thinking of Mika and Jarkko here.  I did remember you used to work on
> some of the PXA handhelds!
> 
> > All of this brings me to the next point : Mika, wouldn't you add yourself as
> > spi-pxa2xx maintainer ? I can't recall if it's for Edison or another platform,
> > but you contribute a lot to spi-pxa2xx, so wouldn't it make sense ?
> 
> Yeah.

Jarkko Nikula (CC'd) has been taking care of this driver lately. I would
recommend him to be listed as a maintainer if this driver. If it is OK
for him, that is.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html