* [PATCH] spi: nxp-fspi: use the correct ioremap function
@ 2023-10-10 20:15 Han Xu
2023-10-16 15:11 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Han Xu @ 2023-10-10 20:15 UTC (permalink / raw)
To: Han Xu, Haibo Chen, Yogesh Gaur, Mark Brown, Adam Ford
Cc: linux-spi, linux-kernel
AHB memory as MMIO should be mapped with ioremap rather than ioremap_wc,
which should have been used initially just to handle unaligned access as
a workaround.
Fixes: d166a73503ef ("spi: fspi: dynamically alloc AHB memory")
Signed-off-by: Han Xu <han.xu@nxp.com>
---
drivers/spi/spi-nxp-fspi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c
index 65408056daa8..e13f678f2395 100644
--- a/drivers/spi/spi-nxp-fspi.c
+++ b/drivers/spi/spi-nxp-fspi.c
@@ -759,7 +759,7 @@ static int nxp_fspi_read_ahb(struct nxp_fspi *f, const struct spi_mem_op *op)
f->memmap_len = len > NXP_FSPI_MIN_IOMAP ?
len : NXP_FSPI_MIN_IOMAP;
- f->ahb_addr = ioremap_wc(f->memmap_phy + f->memmap_start,
+ f->ahb_addr = ioremap(f->memmap_phy + f->memmap_start,
f->memmap_len);
if (!f->ahb_addr) {
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] spi: nxp-fspi: use the correct ioremap function
2023-10-10 20:15 [PATCH] spi: nxp-fspi: use the correct ioremap function Han Xu
@ 2023-10-16 15:11 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2023-10-16 15:11 UTC (permalink / raw)
To: Haibo Chen, Yogesh Gaur, Adam Ford, Han Xu; +Cc: linux-spi, linux-kernel
On Tue, 10 Oct 2023 15:15:24 -0500, Han Xu wrote:
> AHB memory as MMIO should be mapped with ioremap rather than ioremap_wc,
> which should have been used initially just to handle unaligned access as
> a workaround.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: nxp-fspi: use the correct ioremap function
commit: c3aa5cb264a38ae9bbcce32abca4c155af0456df
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-16 15:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-10 20:15 [PATCH] spi: nxp-fspi: use the correct ioremap function Han Xu
2023-10-16 15:11 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox