[PATCH] Revert "spi: cadence: Add SPI transfer delays"

[PATCH] Revert "spi: cadence: Add SPI transfer delays"

[Nam Cao]

This reverts commit 855a40cd8cccfbf5597adfa77f55cdc8c44b6e42.

SPI transfer delay is already handled in SPI core. There is no need to
do it again.

Signed-off-by: Nam Cao <namcao@linutronix.de>
---
 drivers/spi/spi-cadence.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c
index 12c940ba074a..bd96d8b546cd 100644
--- a/drivers/spi/spi-cadence.c
+++ b/drivers/spi/spi-cadence.c
@@ -451,7 +451,6 @@ static int cdns_transfer_one(struct spi_controller *ctlr,
 		udelay(10);
 
 	cdns_spi_process_fifo(xspi, xspi->tx_fifo_depth, 0);
-	spi_transfer_delay_exec(transfer);
 
 	cdns_spi_write(xspi, CDNS_SPI_IER, CDNS_SPI_IXR_DEFAULT);
 	return transfer->len;
-- 
2.39.2

Re: [PATCH] Revert "spi: cadence: Add SPI transfer delays"

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 836 bytes --]

On Wed, Dec 06, 2023 at 02:44:46PM +0100, Nam Cao wrote:
> This reverts commit 855a40cd8cccfbf5597adfa77f55cdc8c44b6e42.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] Revert "spi: cadence: Add SPI transfer delays"

[Nam Cao]

On Wed, 6 Dec 2023 13:55:30 +0000 Mark Brown <broonie@kernel.org> wrote:
> On Wed, Dec 06, 2023 at 02:44:46PM +0100, Nam Cao wrote:
> > This reverts commit 855a40cd8cccfbf5597adfa77f55cdc8c44b6e42.  
> 
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
> 
> Please include human readable descriptions of things like commits and
> issues being discussed in e-mail in your mails, this makes them much
> easier for humans to read especially when they have no internet access.
> I do frequently catch up on my mail on flights or while otherwise
> travelling so this is even more pressing for me than just being about
> making things a bit easier to read.

Okay, will send a v2 shortly. Sorry for the inconvenience.

Best regards,
Nam