From: Andres Urian Florez <andres.emb.sys@gmail.com>
To: dlechner@baylibre.com, broonie@kernel.org
Cc: Andres Urian Florez <andres.emb.sys@gmail.com>,
skhan@linuxfoundation.org, linux-spi@vger.kernel.org
Subject: [PATCH] spi: offload: check ops and match pointers before use
Date: Thu, 17 Apr 2025 18:23:16 -0500 [thread overview]
Message-ID: <20250417232319.384094-1-andres.emb.sys@gmail.com> (raw)
Before checking if one of the triggers matches, check if 'ops' and 'match'
exist
Signed-off-by: Andres Urian Florez <andres.emb.sys@gmail.com>
---
drivers/spi/spi-offload.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-offload.c b/drivers/spi/spi-offload.c
index 6bad042fe437..fcb226887488 100644
--- a/drivers/spi/spi-offload.c
+++ b/drivers/spi/spi-offload.c
@@ -173,7 +173,9 @@ static struct spi_offload_trigger
if (trigger->fwnode != args->fwnode)
continue;
- match = trigger->ops->match(trigger, type, args->args, args->nargs);
+ if (trigger->ops && trigger->ops->match)
+ match = trigger->ops->match(trigger, type, args->args, args->nargs);
+
if (match)
break;
}
--
2.43.0
next reply other threads:[~2025-04-17 23:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 23:23 Andres Urian Florez [this message]
2025-04-18 14:20 ` [PATCH] spi: offload: check ops and match pointers before use David Lechner
2025-04-18 16:37 ` Andres Urian
2025-04-18 16:45 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250417232319.384094-1-andres.emb.sys@gmail.com \
--to=andres.emb.sys@gmail.com \
--cc=broonie@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-spi@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox