From: David Lechner <dlechner@baylibre.com>
To: Andres Urian <andres.emb.sys@gmail.com>
Cc: broonie@kernel.org, skhan@linuxfoundation.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: offload: check ops and match pointers before use
Date: Fri, 18 Apr 2025 11:45:21 -0500 [thread overview]
Message-ID: <c6177e8a-f024-452e-80d4-a801410ce05e@baylibre.com> (raw)
In-Reply-To: <CAMihqu_GcW9PuXdacfNSop8MByh1O6RkczAO7WphFpCAxcm8Tg@mail.gmail.com>
On 4/18/25 11:37 AM, Andres Urian wrote:
> Hi David.
>
> Thanks for your comments! I did not see the full picture and now it is
> clear to me that it is not required to check the trigger->ops in
> spi_offload_trigger_get().
>
> Then I will create another patch to remove the trigger->ops check that you
> mentioned in spi_offload_trigger_get, and make match a required callback
> in devm_spi_offload_trigger_register() instead.
To save some future review, I would consider these two separate changes and put
them in two separate patches.
prev parent reply other threads:[~2025-04-18 16:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 23:23 [PATCH] spi: offload: check ops and match pointers before use Andres Urian Florez
2025-04-18 14:20 ` David Lechner
2025-04-18 16:37 ` Andres Urian
2025-04-18 16:45 ` David Lechner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6177e8a-f024-452e-80d4-a801410ce05e@baylibre.com \
--to=dlechner@baylibre.com \
--cc=andres.emb.sys@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox