From: Andres Urian Florez <andres.emb.sys@gmail.com>
To: dlechner@baylibre.com, broonie@kernel.org
Cc: Andres Urian Florez <andres.emb.sys@gmail.com>,
skhan@linuxfoundation.org, linux-spi@vger.kernel.org
Subject: [PATCH] spi: offload: check offload ops existence before disabling the trigger
Date: Sun, 8 Jun 2025 18:04:21 -0500 [thread overview]
Message-ID: <20250608230422.325360-1-andres.emb.sys@gmail.com> (raw)
Add a safe guard in spi_offload_trigger to check the existence of
offload->ops before invoking the trigger_disable callback
Signed-off-by: Andres Urian Florez <andres.emb.sys@gmail.com>
---
drivers/spi/spi-offload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-offload.c b/drivers/spi/spi-offload.c
index e674097bf3be..d336f4d228d5 100644
--- a/drivers/spi/spi-offload.c
+++ b/drivers/spi/spi-offload.c
@@ -297,7 +297,7 @@ int spi_offload_trigger_enable(struct spi_offload *offload,
if (trigger->ops->enable) {
ret = trigger->ops->enable(trigger, config);
if (ret) {
- if (offload->ops->trigger_disable)
+ if (offload->ops && offload->ops->trigger_disable)
offload->ops->trigger_disable(offload);
return ret;
}
--
2.43.0
next reply other threads:[~2025-06-08 23:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-08 23:04 Andres Urian Florez [this message]
2025-06-09 13:46 ` [PATCH] spi: offload: check offload ops existence before disabling the trigger David Lechner
2025-06-09 15:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250608230422.325360-1-andres.emb.sys@gmail.com \
--to=andres.emb.sys@gmail.com \
--cc=broonie@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-spi@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox