Re: [PATCH] spi: offload: check offload ops existence before disabling the trigger

[David Lechner <dlechner@baylibre.com>]

On 6/8/25 6:04 PM, Andres Urian Florez wrote:
> Add a safe guard in spi_offload_trigger to check the existence of
> offload->ops before invoking the trigger_disable callback
> 
> Signed-off-by: Andres Urian Florez <andres.emb.sys@gmail.com>
> ---
>  drivers/spi/spi-offload.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-offload.c b/drivers/spi/spi-offload.c
> index e674097bf3be..d336f4d228d5 100644
> --- a/drivers/spi/spi-offload.c
> +++ b/drivers/spi/spi-offload.c
> @@ -297,7 +297,7 @@ int spi_offload_trigger_enable(struct spi_offload *offload,
>  	if (trigger->ops->enable) {
>  		ret = trigger->ops->enable(trigger, config);
>  		if (ret) {
> -			if (offload->ops->trigger_disable)
> +			if (offload->ops && offload->ops->trigger_disable)
>  				offload->ops->trigger_disable(offload);
>  			return ret;
>  		}

It would be unusual to have an enable callback without also having
a disable callback, but to be symmetric with the same call in
spi_offload_trigger_disable(), it seems fine to add this check.

Reviewed-by: David Lechner <dlechner@baylibre.com>