public inbox for linux-spi@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2/2 v2] devicetree: spi: add spi-mosi-idle-low property support
@ 2026-03-29 12:58 charles-antoine.couret
  2026-03-29 14:32 ` Marcelo Schmitt
  2026-03-30  7:16 ` Krzysztof Kozlowski
  0 siblings, 2 replies; 5+ messages in thread
From: charles-antoine.couret @ 2026-03-29 12:58 UTC (permalink / raw)
  To: broonie, robh, krzk+dt, conor+dt
  Cc: linux-spi, devicetree, linux-kernel, Charles-Antoine Couret

From: Charles-Antoine Couret <charles-antoine.couret@mind.be>

This flag means that device requires the MOSI line to be low
when it's in idle state.

Signed-off-by: Charles-Antoine Couret <charles-antoine.couret@mind.be>
---
 Documentation/devicetree/bindings/spi/spi-controller.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/spi/spi-controller.yaml b/Documentation/devicetree/bindings/spi/spi-controller.yaml
index 3b8e990e30c4..5f5b143cb27b 100644
--- a/Documentation/devicetree/bindings/spi/spi-controller.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-controller.yaml
@@ -132,6 +132,11 @@ patternProperties:
         description:
           The device requires inverse clock polarity (CPOL) mode.
 
+      spi-mosi-idle-low:
+        $ref: /schemas/types.yaml#/definitions/flag
+        description:
+          The device requires the MOSI line to be low when it's in idle state.
+
     required:
       - compatible
       - reg
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2 v2] devicetree: spi: add spi-mosi-idle-low property support
  2026-03-29 12:58 [PATCH 2/2 v2] devicetree: spi: add spi-mosi-idle-low property support charles-antoine.couret
@ 2026-03-29 14:32 ` Marcelo Schmitt
  2026-03-29 15:19   ` Krzysztof Kozlowski
  2026-03-30  7:16 ` Krzysztof Kozlowski
  1 sibling, 1 reply; 5+ messages in thread
From: Marcelo Schmitt @ 2026-03-29 14:32 UTC (permalink / raw)
  To: charles-antoine.couret
  Cc: broonie, robh, krzk+dt, conor+dt, linux-spi, devicetree,
	linux-kernel

On 03/29, charles-antoine.couret@mind.be wrote:
> From: Charles-Antoine Couret <charles-antoine.couret@mind.be>
> 
> This flag means that device requires the MOSI line to be low
> when it's in idle state.

Same question asked on the other patch [1] applies here.

By the way, for SPI bindings, the patch subject uses a different prefix order.
See submitting-patches.rst [2].

[1]: https://lore.kernel.org/linux-spi/ack2dPiLpO0uE2VE@debian-BULLSEYE-live-builder-AMD64/
[2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/submitting-patches.rst?h=v7.0-rc5#n18

> 
> Signed-off-by: Charles-Antoine Couret <charles-antoine.couret@mind.be>
> ---
>  Documentation/devicetree/bindings/spi/spi-controller.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-controller.yaml b/Documentation/devicetree/bindings/spi/spi-controller.yaml
> index 3b8e990e30c4..5f5b143cb27b 100644
> --- a/Documentation/devicetree/bindings/spi/spi-controller.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-controller.yaml
> @@ -132,6 +132,11 @@ patternProperties:
>          description:
>            The device requires inverse clock polarity (CPOL) mode.
>  
> +      spi-mosi-idle-low:
> +        $ref: /schemas/types.yaml#/definitions/flag
> +        description:
> +          The device requires the MOSI line to be low when it's in idle state.
> +
>      required:
>        - compatible
>        - reg
> -- 
> 2.53.0
> 
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2 v2] devicetree: spi: add spi-mosi-idle-low property support
  2026-03-29 14:32 ` Marcelo Schmitt
@ 2026-03-29 15:19   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-29 15:19 UTC (permalink / raw)
  To: Marcelo Schmitt, charles-antoine.couret
  Cc: broonie, robh, krzk+dt, conor+dt, linux-spi, devicetree,
	linux-kernel

On 29/03/2026 16:32, Marcelo Schmitt wrote:
> On 03/29, charles-antoine.couret@mind.be wrote:
>> From: Charles-Antoine Couret <charles-antoine.couret@mind.be>
>>
>> This flag means that device requires the MOSI line to be low
>> when it's in idle state.
> 
> Same question asked on the other patch [1] applies here.
> 
> By the way, for SPI bindings, the patch subject uses a different prefix order.
> See submitting-patches.rst [2].
> 
> [1]: https://lore.kernel.org/linux-spi/ack2dPiLpO0uE2VE@debian-BULLSEYE-live-builder-AMD64/
> [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/submitting-patches.rst?h=v7.0-rc5#n18
> 


They also do not use "devicetree" prefix at all. Nowhere...

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2 v2] devicetree: spi: add spi-mosi-idle-low property support
  2026-03-29 12:58 [PATCH 2/2 v2] devicetree: spi: add spi-mosi-idle-low property support charles-antoine.couret
  2026-03-29 14:32 ` Marcelo Schmitt
@ 2026-03-30  7:16 ` Krzysztof Kozlowski
  2026-03-30 14:41   ` Mark Brown
  1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-30  7:16 UTC (permalink / raw)
  To: charles-antoine.couret
  Cc: broonie, robh, krzk+dt, conor+dt, linux-spi, devicetree,
	linux-kernel

On Sun, Mar 29, 2026 at 02:58:32PM +0200, charles-antoine.couret@mind.be wrote:
> From: Charles-Antoine Couret <charles-antoine.couret@mind.be>
> 
> This flag means that device requires the MOSI line to be low
> when it's in idle state.
> 
> Signed-off-by: Charles-Antoine Couret <charles-antoine.couret@mind.be>
> ---
>  Documentation/devicetree/bindings/spi/spi-controller.yaml | 5 +++++
>  1 file changed, 5 insertions(+)


There is no patch 1/2 here, even on mailing lists, so probably this has
messed threading.

Please use subject prefixes matching the subsystem. You can get them for
example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2 v2] devicetree: spi: add spi-mosi-idle-low property support
  2026-03-30  7:16 ` Krzysztof Kozlowski
@ 2026-03-30 14:41   ` Mark Brown
  0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2026-03-30 14:41 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: charles-antoine.couret, robh, krzk+dt, conor+dt, linux-spi,
	devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

On Mon, Mar 30, 2026 at 09:16:56AM +0200, Krzysztof Kozlowski wrote:
> On Sun, Mar 29, 2026 at 02:58:32PM +0200, charles-antoine.couret@mind.be wrote:

> > This flag means that device requires the MOSI line to be low
> > when it's in idle state.

> There is no patch 1/2 here, even on mailing lists, so probably this has
> messed threading.

Yes: https://lore.kernel.org/r/20260329125725.2984756-1-charles-antoine.couret@mind.be

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-03-30 14:41 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-29 12:58 [PATCH 2/2 v2] devicetree: spi: add spi-mosi-idle-low property support charles-antoine.couret
2026-03-29 14:32 ` Marcelo Schmitt
2026-03-29 15:19   ` Krzysztof Kozlowski
2026-03-30  7:16 ` Krzysztof Kozlowski
2026-03-30 14:41   ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox